BGRASVGImageList saves different binary format per platform (patch available) about bgracontrols HOT 15 CLOSED

bgracontrols\test\test_bgrathemes\umain.lfm (original is in the repo)

this is the saved with the new code
umain.zip

from bgracontrols.

@circular17, now it works perfectly =)

from bgracontrols.

Hello @dokkie8844

Thank you for the detailed explanation and patch. Your diagnostic and proposal seem sound. Normalizing the end of lines when saving would ensure that they are stable.

Thinking about the issue, we could go further in avoiding changes in LFM files by detecting the line ending when loading the configuration and use the same line ending when saving.

@lainz Hope you're doing alright. Are you available to handle this query? I can take care of it otherwise.

Regards

from bgracontrols.

Hi @circular17 , please take care of this.
Thanks.

from bgracontrols.

Ok I will try to add that to my todo list

from bgracontrols.

Hi @lainz and @dokkie8844

I've implemented the change. Though I cannot test it. Can you try and see if line ending are preserved?

Regards

from bgracontrols.

Hi @circular17 , I've tested it this way on Windows 11:

• Download latest sources
• Rebuild lazarus
• Open a form previously saved with the old code
• Move any non visual component and save the form

It produces changes in the SVG Image List... so for me as I undestand didn't work.

from bgracontrols.

Thanks @lainz for testing. Can you give more detail on the changes that happen?

from bgracontrols.

Not really. Is like a hex format I can't easily read it. Also takes a lot of time to load the form I've used to test (a big form full of stuff).

Maybe you can go back the code and create a form. Then test with the new code in a git repository to track changes?

Is what I did without good results... But maybe you can understand the changes in the lfm...

from bgracontrols.

Ok so you notice a change in the data that is generated. Can you provide the file before and after?

from bgracontrols.

Sorry is from a commercial application. I can't share.

from bgracontrols.

Ok. Maybe a test project if there is one already?

@dokkie8844 Can you help testing and debugging? The changes are on the dev-bgracontrols branch.

from bgracontrols.

Ah indeed there are some line endings that have been adapted, but within HTML. Ok this is in the string containing the SVG. It is an XML within the XML. I suppose it is because each SVG is stored as a TStringList. I am investigating...

from bgracontrols.

@lainz I've added a call to adapt the line breaks inside the SVGs as well. I suppose now it will be ok. Can you give it a try?

from bgracontrols.

Cool! Thank you so much for testing.

Well i guess we can consider the issue done!

Thank you @dokkie8844 for the request

from bgracontrols.