Comments (4)
mockersf
commented on August 15, 2024
2
Pre commit hooks offer no guarantee, as they have to be installed by the contributor to do anything...
I'm also heavily against them, they're mostly an added annoyance without bringing anything
from bevy.
alice-i-cecile
commented on August 15, 2024
What are the pros and cons of a pre-commit hook vs a triggerable bot? @BD103 @mockersf do either of you have opinions here?
from bevy.
IceSentry
commented on August 15, 2024
I'm heavily against pre-commit hooks. It's really annoying to have to wait on hooks before comitting anything. Most contributors are already aware of clippy and CI currently doesn't cost anything.
from bevy.
BobG1983
commented on August 15, 2024
Mostly cost I would assume.
I get the response when I try and commit locally, including on my own branches, rather than having to wait till a PR is opened.
…---
"Of all the things I've lost, I miss my mind the most" - Ozzy Osbourne
On Monday, June 24th, 2024 at 11:15 AM, Alice Cecile ***@***.***> wrote:
What are the pros and cons of a pre-commit hook vs a triggerable bot? ***@***.***(https://github.com/BD103) ***@***.***(https://github.com/mockersf) do either of you have opinions here?
—
Reply to this email directly, [view it on GitHub](#14002 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAWAGGATEBFWOXEHZXZGIS3ZJBO3PAVCNFSM6AAAAABJ2J3NMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGE2DIMBTGI).
You are receiving this because you authored the thread.Message ID: ***@***.***>
from bevy.
Related Issues (20)
- 0.14 Windows 11 bug: Invisible App Window stuck at frame 1 and never render after HOT 5
- Linker error when using meshlet_processor feature on Linux HOT 2
- Reflect dynamic components / type registrations for dynamic types HOT 1
- Improve color grading: Hue shift based on shadows/midtones/highlights
- Viewport debug example in web has a visual difference between the two uinode trees HOT 1
- Decouple *what* plugins do from *when* they do it HOT 1
- Volumetric fog broken on WASM HOT 1
- Can not load 3D examples on the website HOT 7
- Meshlet example fails to compile HOT 3
- Reflect: Support for Atomic values
- Sprite AABB does not seem to update with position of the sprites
- Add a rect field to UiImage HOT 2
- Segmentation fault trying to run 2d_shapes example on NixOs wayland with AMD GPU HOT 6
- Helper methods on `Transform` HOT 2
- Add `AssetPath::exists` HOT 1
- Allow query transmutation with immutable query references HOT 4
- Unify `CursorIcon` management. HOT 1
- Implement FromStr and TryFrom for ParsedPath HOT 2
- Improve docs on bloom HOT 1
- Add change ticks to asset references
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bevy.