Git Product home page Git Product logo

Comments (6)

NthTensor avatar NthTensor commented on June 4, 2024

Might be better to use a private pair of orthonormal vectors. Would downgrade normal to a function, so would be a breaking change.

from bevy.

mweatherley avatar mweatherley commented on June 4, 2024

Might be better to use a private pair of orthonormal vectors. Would downgrade normal to a function, so would be a breaking change.

I like this idea.

from bevy.

rlidwka avatar rlidwka commented on June 4, 2024

@mweatherley, I have a question though. If Plane3d represents a "rectangular section of an infinite plane", then what does Plane2d represent?

pub struct Plane3d {
    /// The normal of the plane. The plane will be placed perpendicular to this direction
    pub normal: Dir3,
    /// Half of the width and height of the plane
    pub half_size: Vec2,
}

pub struct Plane2d {
    /// The normal of the plane. The plane will be placed perpendicular to this direction
    pub normal: Dir2,
}                                                                                                                       

I believe these two things should be pushed back to the drawing board.

from bevy.

NthTensor avatar NthTensor commented on June 4, 2024

I think plane2d is actually an infinite line iirc. Yeah, the situation is not great.

from bevy.

Jondolf avatar Jondolf commented on June 4, 2024

Honestly, I'm not sure we even need Plane2d since we already have Line2d. The only real difference is just that they're perpendicular to one another (the plane has a normal and the line has a direction).

from bevy.

NthTensor avatar NthTensor commented on June 4, 2024

Good point. The only thing Line2d is missing is a right-handed normal() -> Dir2 method.

from bevy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.