Property `modified` on parentform not updated when childform was removed about angular-input-modified HOT 4 OPEN

I've pushed some changes and released a new version: 2.4.0. You can see it in action here: http://betsol.github.io/angular-input-modified/nested-forms/. Please let me know if it works for you. Cheers!

from angular-input-modified.

Hello! Thank you for your interest in this module and sorry for a late reply.

The module itself was not actually designed for dynamic forms. Right now, we have an internal list of modified child forms, so when you remove the child form from the DOM, the directive doesn't know about it and keeps tracking it in it's internal list of changed forms. In order to solve your issue we need to somehow synchronize this list with the actual forms in DOM.

I will think about it. Thank you for a report. Also, if you have any suggestions, I will be glad to discuss them.

from angular-input-modified.

First of all, thank you for maintaining this module. The behaviour described above however should be "optional". A lot of us (i think?) greatly use the fact that when you remove subforms/items the modified flag remains true. Updating to this new version was impossible for me as a lot of "dirty state" behaviour is now reset when a form is temporarily removed from the DOM. And yes, i know it can never be "unmodified" again when it gets added back to the DOM, in our case this is expected behaviour. Leaving the sub-page will mark it as dirty indefinatly (untill saved).

So i'm stuck at 2.3.4.

TLDR; Any chance this could be configurable behaviour?

from angular-input-modified.

Hello @DoubleDot, thank you for your interest.

Could you please describe your use case in more detail? I think the fixes introduced are correct ones and the behavior you are describing is actually could be considered a bug, because the modified state of the form should always be derived from all child fields and forms, so when child form is removed from the DOM, we are now re-checking the modification state according to the actual state of the form and all it's children.

If you would describe your use case in more details I will be glad to offer you some suggestions or to look at the problem from another angle.

from angular-input-modified.