Comments (9)
thanks for your contribution, could you be a little more specific about the check_url config ?
In which scenario is curl timeout used ?
You are proposing a 5 seconds timeout to reach the SSO ?
Thanks
from besimplessoauthbundle.
- check_url allow to choose the url to redirect after the SSO authentication. You can see it in the service parameter : https://www.example-cas-server.com/cas/login?service=https://www.final_url.com
Configuration :
be_simple_sso_auth:
admin_sso:
server:
id: cas
...
check_url: https://www.final_url.com
- The timeout can be useful to define if the SSO take time to reach. I suggest 5 seconds by default, but you can change it easily by configuration
from besimplessoauthbundle.
Salut @clement-garrigou
ok pour le timeout
par contre, y'a un truc que je ne comprend vraiment pas... dans ta propostion du Factory.php, j'ai testé et ça fonctionne comme convenu
mais je vois pas en quoi de rajouter la vérification du !isset change quelquechose
A l'origine, le code force la valeur du check_url dans tous les cas... y'a un truc que j'ai loupé ?
from besimplessoauthbundle.
Ok, j'ai cherché un peu en remontant ici :
$manager = $this->factory->getManager($this->config['manager'], $request->getUriForPath($this->config['check_path']));
A priori, ici le check_url est systématiquement écrasé par la valeur de 'check_path', check path étant une propriété de security.yml
On devrait corriger cette portion plutot pour que ça soit logique, qu'en penses tu ?
from besimplessoauthbundle.
OK sur le principe c'est vrai que ça semble plus logique.
Mais ça fait changer aussi https://github.com/clement-garrigou/BeSimpleSsoAuthBundle/blob/master/Security/Http/Firewall/TrustedSsoAuthenticationListener.php et https://github.com/clement-garrigou/BeSimpleSsoAuthBundle/blob/master/Security/Http/Logout/SsoLogoutSuccessHandler.php non ?
Et à ce moment là on a pas la valeur de check_url, donc ça fait changer pas mal de choses non ?
from besimplessoauthbundle.
Oui effectivement, c'est plus compliqué qu'il n'y parait car il faudrait en plus injecter la config du bundle dans l'authentication car check_url n'est pas un paramètre standard du security framework de symfony...
Par contre, une idée juste comme ça, tu as testé d'utiliser le paramètre 'check_path' comme 'check_url' dans ton contexte ? Car au final, cela reviendrait au même non ?
from besimplessoauthbundle.
J'ai testé : check_path sert à modifier le path de l'url de retour. On ne peut pas l'utiliser pour changer complétement l'url de retour, ce qui serait possible avec check_url.
from besimplessoauthbundle.
J'ai mergé la PR, désolé pour le temps pris pour l'analyse ^^
Je ne sais pas si ce projet est connecté à l'API de packagist.org du coup, ça risque de prendre 24h à 48h pour disposer de la mise à jour sur composer
Merci pour ta contribution et à bientot,
James
from besimplessoauthbundle.
Merci !
from besimplessoauthbundle.
Related Issues (20)
- <url> malformed 500 Internal Server Error - ClientException HOT 1
- Unable to find the controller for path "/login_check", in some cases
- Error: Call to a member function validateCredentials() on a non-object in /var/www/udaweblabs/vendor/besimple/sso-auth-bundle/BeSimple/SsoAuthBundle/Security/Core/Authentication/Provider/SsoAuthenticationProvider.php line 78 HOT 2
- Cannot make this working due to do not know how to configure it HOT 2
- Exception thrown when user needs to be re-authenticated HOT 3
- Manually create token for functional tests?
- How to get attributes from CAS while using this bundle? HOT 1
- Need help about BeSimpleSsoAuthBundle comprehension
- Problème de redirection HOT 2
- loginAction() requires that you provide a value for the "$manager" argument / Symfony 2.5 HOT 2
- Forced SSLv3 HOT 4
- Problem in bundle configuration
- Is this working with SAML?
- Check periodicaly authentication against the CAS portal HOT 1
- SSL certificate problem: self signed certificate HOT 1
- Compatibility with Symfony ~3.0 HOT 4
- cannot dump configuration HOT 3
- Not Working since I upgraded my workstation on Ubuntu 16.04 HOT 1
- Make compatible with Symfony 4 HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from besimplessoauthbundle.