Comments (9)
If I manually install keytar with npm i keytar
then it works.
I am using Mac OS X Monterrey 12.3.1
And I see it is declared as an optional dependency. Perhaps it should be declared as a peer dependency?
from chrome-cookies-secure.
What Node version? Seems OK to me running a very simplified version on Node 10.22.0
.
keytar
is only used in the context of darwin
/mac in the codebase so it's redundant for other OS but it would be interesting to know which Node version, I'm also on Monterey 12.3.1
from chrome-cookies-secure.
Oh sorry, I forgot to share the Node version. It is 16.14.0
.
And it is so strange, now I created a new project from scratch with chrome-cookies-secure
version 1.3.4
and it was working ...
I don't know the nitty gritty of how optional dependencies get handled but clearly here it did a strange job. I need to say that in the original project I had version 1.3.2 from the beginning, then I bumped into 1.3.3, whereas in this new project from scratch I started straight away from version 1.3.4
.
Thanks for the support!
from chrome-cookies-secure.
From the documentation I can find, optionalDependencies
- if for some reason they fail to install - do not block the overall install pipeline and npm
will carry on as if nothing happened:
https://docs.npmjs.com/cli/v7/configuring-npm/package-json#optionaldependencies
keytar
is only required for process.platform === darwin
so if it fails to install on windows
or linux
, that's fine, but when it fails on macOS
that's just not going to work.
We also have win-dpapi
where the same would apply to windows
I'm not sure on the technicalities of making certain dependencies required only on certain operating systems, but it seems safer at least to just move these to dependencies
to eradicate the possibility of this happening.
from chrome-cookies-secure.
I've created a draft PR for this here #44 (comment) which should do the trick.
from chrome-cookies-secure.
Turns out moving at least one of these (win-dpapi
) to dependencies
completely breaks the install on macOS. npm i
complains that the required dependency does not fit the platform.
I've reverted to optionalDependencies
.
from chrome-cookies-secure.
@josep11 have you run into this problem since?
from chrome-cookies-secure.
Related Issues (20)
- Upgrade sqlite3 version
- Crashing on require HOT 1
- fails on google HOT 5
- Decryption failed. TODO: Error code HOT 1
- fail: unable to open database file HOT 19
- Add a typescript definition file HOT 4
- sqlite3 forces native compilation in electron HOT 2
- Support for custom configs and allowing Chromium/Blink browsers HOT 1
- Sqlite not working on Ubuntu 18.04 HOT 2
- No types file for chrome-cookies-secure HOT 3
- Can't fetch cookies on windows HOT 4
- Cookies Database Moving in Chrome 96 HOT 4
- OSX: Error: The user name or passphrase you entered is not correct. HOT 1
- Need help understanding how to decrypt for Chromium HOT 1
- Error running through SSH HOT 6
- Brave permissions HOT 1
- select all cookies? HOT 1
- Chrome 114 "Lock profile cookie files on disk" HOT 3
- Doesn't work for Apple M1 (or M2) based machines HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chrome-cookies-secure.