Git Product home page Git Product logo

Comments (2)

Beomi avatar Beomi commented on June 4, 2024

안녕하세요.

https://flax.readthedocs.io/en/latest/api_reference/flax.linen/activation_functions.html#flax.linen.activation.gelu

현재 레포는 pytorch가 아닌 Jax/Flax 구현체이며,
해당 이슈들은 Pytorch구현체쪽에만 있는 이슈입니다.

Act func의 approx는 위 링크에서 확인할 수 있듯 flax의 경우 이미 기본 gelu는 approx=True옵션이 기본입니다 :)

따라서 continual pretrain에서 문제는 없었을 것으로 보이고요,
일반 HF+PyTorch 사용자분들을 위한 config 수정은 해당 항목을 지우는 방향으로 수정해봐야겠네요.
(만약 pytorch로 수정할 경우 flax등에서 로딩에러가 날 것 같습니다.)

from gemma-easylm.

HeegyuKim avatar HeegyuKim commented on June 4, 2024

아아 그렇군요 ! 늦은 시간에 답변 감사합니다!

from gemma-easylm.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.