Git Product home page Git Product logo

Comments (5)

parano avatar parano commented on May 24, 2024

Hi @rishin27 - BentoML internally uses async everywhere for better performance, so this might be an internal issue with BentoML on Yatai, that's not related to user code. May I ask what's the BentoML and Yatai version that you are using?

Note that when a Bento is deployed on Yatai, Runners are by default scheduled as their own separate pods, in order to scale separately from the service code. The async code path is used for converting the runner.run function call into an async RPC call. This might be an issue with how the deployment and runner communication was set up.

from yatai.

rishin27 avatar rishin27 commented on May 24, 2024

Hi @parano Thanks for the info. I get that yatai is build for autoscaling & kubernetes workload magic. But if the user has nowhere marked their code as async, is it right to send it by default to the async code path ?
The general workflow for a data scientist will be that they'll build the model, save it using bento, check if the service is working using 'bentoml serve'... if everything works out will push it to the yatai server for the deployment. But then if yatai adds async magic (which was not intended) and thing start breaking, it'll not be a good UX.

Yatai - v0.3.1-c3dab74
bentoml - v1.0.0a7

from yatai.

parano avatar parano commented on May 24, 2024

Thanks @rishin27, we will look into this issue more. Ideally by design, if the bentoml serve works locally, it should definitely work on Yatai. Note that Yatai is still in its alpha release so definitely expect some rough edges at the moment.

But if the user has nowhere marked their code as async, is it right to send it by default to the async code path ?

This is actually fairly common in python web frameworks, such as Sanic or FastAPI, where both sync and async handlers can be defined by the user, the framework uses async internally. BentoML server uses async even without Yatai. I think the root cause of the issue is likely not about async, but some settings with the distributed runner setup in yatai deployment.

from yatai.

rishin27 avatar rishin27 commented on May 24, 2024

Thanks @parano for your detailed answer.
Do let me know if i can help, happy to contribute.

from yatai.

parano avatar parano commented on May 24, 2024

Hi @rishin27, could you try it again with the latest version of BentoML and Yatai? The issue should be resolved by now.

from yatai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.