Comments (3)
Yep, I'd support a darkmode/lightmode feature.
GoodJob uses vanilla Bootstrap. I want to keep it that way, but Bootstrap does have support for color modes as of Bootstrap v5.3 (GoodJob currently uses v5.2 so you'd also need to update that, but it should be real easy to just replace these files):
https://getbootstrap.com/docs/5.3/customize/color-modes/#how-it-works
I'm imagining the visual implementation would be similar to the language selector (e.g. a small dropdown in the header with options for light/dark/auto).
Also, I can imagine that there will be lots of visual oddities and tweaks, but we can work through those issues once we have the basic functionality/demo-ability working. I'm very happy to accept a Dark mode PR that isn't perfect but has enough of the functionality working for other people to report bugs or tweak it later. The goal should be to demonstrate the capability, not perfection.
from good_job.
Hey Ben, thanks for being open to the idea 🙌
I haven't touched Bootstrap for quite some times now and I'm not really in a mood to get into that right now.
As soon I have some time for this I'll have a look at whether this issue is still open or not and I'll let you know !
Cheers
from good_job.
No sweat! I appreciate you opening the issue; maybe I'll get to it first 😊
from good_job.
Related Issues (20)
- Idea / feature request - deferring execution of batch jobs while still writing them to the database HOT 3
- ActiveSupport::CurrentAttributes reset after `perform_later` HOT 3
- Potential documentation error in GoodJob::ActiveJobExtensions::NotifyOptions HOT 2
- Proposal: Migrating Documentation to a Separate Website HOT 1
- `erb_lint` doesn't lint all files HOT 1
- Executing perform_now on a good_job with GoodJobs::ActiveJobExtensions::Concurrency can run twice HOT 7
- How do I add jobs to an existing batch? HOT 7
- ActiveSupport::CurrentAttributes Compatibility HOT 5
- [Feature request] OpenTelemetry - Link job execution to the request which queued it HOT 2
- How to properly handle interrupts HOT 5
- Document how cron with proc works
- [Feature Request] Nested batches: Allow a parent batch to wait on the completion of child batches
- Unable to use labels with kwargs in job initializer HOT 2
- Whitespace in `queues` configuration can cause issues. HOT 2
- throttling not working as one would expect? HOT 2
- `#good_job_labels` retains values across job instances HOT 3
- Undefined `GoodJob::Process.advisory_lockable_column` HOT 3
- Warn on unapplied migrations HOT 2
- NoMethodError: undefined method `<' for nil (process.rb:125 in stale?) HOT 7
- Change how svg images are inserted into partials
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from good_job.