Git Product home page Git Product logo

Comments (3)

bensheldon avatar bensheldon commented on June 11, 2024

Yep, I'd support a darkmode/lightmode feature.

GoodJob uses vanilla Bootstrap. I want to keep it that way, but Bootstrap does have support for color modes as of Bootstrap v5.3 (GoodJob currently uses v5.2 so you'd also need to update that, but it should be real easy to just replace these files):

https://getbootstrap.com/docs/5.3/customize/color-modes/#how-it-works

I'm imagining the visual implementation would be similar to the language selector (e.g. a small dropdown in the header with options for light/dark/auto).

Also, I can imagine that there will be lots of visual oddities and tweaks, but we can work through those issues once we have the basic functionality/demo-ability working. I'm very happy to accept a Dark mode PR that isn't perfect but has enough of the functionality working for other people to report bugs or tweak it later. The goal should be to demonstrate the capability, not perfection.

from good_job.

wJoenn avatar wJoenn commented on June 11, 2024

Hey Ben, thanks for being open to the idea 🙌
I haven't touched Bootstrap for quite some times now and I'm not really in a mood to get into that right now.
As soon I have some time for this I'll have a look at whether this issue is still open or not and I'll let you know !
Cheers

from good_job.

bensheldon avatar bensheldon commented on June 11, 2024

No sweat! I appreciate you opening the issue; maybe I'll get to it first 😊

from good_job.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.