Support for customized job display name about good_job HOT 3 CLOSED

@paul I think my preference is for option 1. BaseExecution#job_display_name. I feel sorta bad about encouraging monkey patching, but that also seems simplest and I don't like that (3) would require deserializing the ActiveJob.

from good_job.

Hi @bensheldon. I'm finally finding some time to tackle this, but I'm struggling getting my monkeypatch loading late enough. In my app, I've tried several ways to load this, eg:

Rails.application.configure do
  ActiveSupport.on_load(:good_job) do
    GoodJob::BaseExecution.prepend(GoodJobDisplayName)
  end
end

but I always end up with a uninitialized constant GoodJob::BaseExecution (NameError).

Do you have any suggestions on how I can trigger the monkeypatch to load late enough? I saw recently in #1004 you added a :good_job_base_record hook, (which also isn't late enough, fwiw). Do you think I also need to add a similar :good_job_base_execution_record hook?

from good_job.

Actually, nevermind. I dug into all the available keys (since they're not really documented), and it looks like ActiveSupport.on_load(:after_initialize) happens late enough in the Rails boot process that GoodJob has finally loaded all its models.

from good_job.