Comments (2)
Yep, those are inconsistent. The simplest and most up-to-date correction would be 2 + ENV.fetch("GOOD_JOB_MAX_THREADS", 5).to_i
That's also a little misleading because GOOD_JOB_MAX_THREADS
isn't the total upperbound of threads, but more like "the default number of threads for a a configured pool" i.e. if you're using multiple pools (like default;other
with the semicolon) that will be GOOD_JOB_MAX_THREADS * number-of-pools
.
There's now a calculator:
good_job/lib/good_job/configuration.rb
Lines 50 to 53 in 988665e
Lastly, it's really not necessary to be precise with this number so long as the the number is larger than the maximum total threads. It would be safest to simply set this to 50
and not worry about it; the Active Record Database Connection Pool will never allocate more connections than it strictly needs. (I've heard rumors that Rails might even remove the pool
size in the future because it's not very useful to configure)
from good_job.
Thanks for the clarification.
from good_job.
Related Issues (20)
- Potential documentation error in GoodJob::ActiveJobExtensions::NotifyOptions HOT 2
- Proposal: Migrating Documentation to a Separate Website HOT 1
- `erb_lint` doesn't lint all files HOT 1
- Executing perform_now on a good_job with GoodJobs::ActiveJobExtensions::Concurrency can run twice HOT 7
- How do I add jobs to an existing batch? HOT 7
- ActiveSupport::CurrentAttributes Compatibility HOT 5
- [Feature request] OpenTelemetry - Link job execution to the request which queued it HOT 2
- How to properly handle interrupts HOT 5
- Document how cron with proc works
- [Feature Request] Nested batches: Allow a parent batch to wait on the completion of child batches
- Unable to use labels with kwargs in job initializer HOT 2
- Whitespace in `queues` configuration can cause issues. HOT 2
- throttling not working as one would expect? HOT 2
- `#good_job_labels` retains values across job instances HOT 3
- Undefined `GoodJob::Process.advisory_lockable_column` HOT 3
- Warn on unapplied migrations HOT 2
- NoMethodError: undefined method `<' for nil (process.rb:125 in stale?) HOT 7
- Change how svg images are inserted into partials
- Tips for debugging/optimizing slow dashboard? (45 second response time) HOT 1
- docs: Basic auth route mount example improvement HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from good_job.