Comments (3)
No prob! I appreciate that you opened an issue; anyone else experiencing this may also search and find it too 🤗
from good_job.
Thanks for opening the issue! I think I understand what's going on here. There was a significant refactor in 3.12.6: #861
Simply, you shouldn't be calling GoodJob.restart
if you don't want to run GoodJob in that process. So my recommendation would be to remove all of that configuration from your config/puma.rb
file, if you're running the $ good_job
CLI separately.
(unrelated, but btw, you almost never want ActiveRecord::Base.establish_connection if defined?(ActiveRecord)
in any Rails 6+ app because it will leak a database connection unnecessarily)
The fuller explanation: that refactor (#861) made a clearer distinction between:
execution_mode:
meaning "how should a job be executed after it is enqueued?" which becomes a responsibility of the Active Job Adapter for where to send the job on enqueue.- The GoodJob part that executes/performs the jobs (the "Capsule") which is controlled by
restart
andshutdown
.
Those two concepts were previously commingled together.
from good_job.
Hi - thanks :) Yeah, we'd read #861 and thought what you suggested might be the right thing, but since it seemed fine (ha!) before 3.12.6, we thought it was worth a ticket ;)
(ActiveRecord::Base.establish_connection =? thanks again. Yes! This is a recently upgraded R5 so that's been missed.)
Thanks so much & for GJ in general :)
from good_job.
Related Issues (20)
- Potential documentation error in GoodJob::ActiveJobExtensions::NotifyOptions HOT 2
- Proposal: Migrating Documentation to a Separate Website HOT 1
- `erb_lint` doesn't lint all files HOT 1
- Executing perform_now on a good_job with GoodJobs::ActiveJobExtensions::Concurrency can run twice HOT 7
- How do I add jobs to an existing batch? HOT 7
- ActiveSupport::CurrentAttributes Compatibility HOT 5
- [Feature request] OpenTelemetry - Link job execution to the request which queued it HOT 2
- How to properly handle interrupts HOT 5
- Document how cron with proc works
- [Feature Request] Nested batches: Allow a parent batch to wait on the completion of child batches
- Unable to use labels with kwargs in job initializer HOT 2
- Whitespace in `queues` configuration can cause issues. HOT 2
- throttling not working as one would expect? HOT 2
- `#good_job_labels` retains values across job instances HOT 3
- Undefined `GoodJob::Process.advisory_lockable_column` HOT 3
- Warn on unapplied migrations HOT 2
- NoMethodError: undefined method `<' for nil (process.rb:125 in stale?) HOT 7
- Change how svg images are inserted into partials
- Tips for debugging/optimizing slow dashboard? (45 second response time) HOT 1
- docs: Basic auth route mount example improvement HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from good_job.