Git Product home page Git Product logo

Comments (15)

LaurentFough avatar LaurentFough commented on August 24, 2024 1

I've created a Homebrew package formula... tested & installed.
Will submit a PR.

Small issue:

  • there's already a Formula named spin, which installs a spin binary.
  • this can be handled with Homebrew's conflicts_with functionality, to prevent the install if the spin package is already installed.
    • may need to looking into linking tailpin spin to tailspin as a cleaner install.
    • ^^ depends on how @bensadeh feels about this.

β€”-
Will also tweak formula for increased Homebrew compliance.

from tailspin.

LaurentFough avatar LaurentFough commented on August 24, 2024 1

Update: temp Formula here: github.com/LaurentFough/ tailspin.rb

Download & Review (of course), then Install with:

$ brew install --formula <path_to>/tailspin.rb

from tailspin.

bensadeh avatar bensadeh commented on August 24, 2024 1

A PR to add tailspin as formula to core has been merged. I haven't had a chance to test it, but in time the tap will be replaced with the core formula.

from tailspin.

bensadeh avatar bensadeh commented on August 24, 2024

Thank you so much, @LaurentFough ! Can't believe how fast that was πŸ™ .

It would be great if the package name could be tailspin and the binary name be spin. Is that possible?

from tailspin.

LaurentFough avatar LaurentFough commented on August 24, 2024

Thank you so much, @LaurentFough ! Can't believe how fast that was πŸ™ .

It would be great if the package name could be tailspin and the binary name be spin. Is that possible?

Thanks @bensadeh
Ok - package is already named: tailspin.
See my previous comment about the conflicting spin package.
β€”-
Would be cleaner for you to rename upstream as tailspin; rather than installing as spin and renaming...

from tailspin.

bensadeh avatar bensadeh commented on August 24, 2024

I prefer spin as the binary name. Besides, tailspin is already a sort of builtin binary on macOS.

from tailspin.

LaurentFough avatar LaurentFough commented on August 24, 2024

I prefer spin as the binary name. Besides, tailspin is already a sort of builtin binary on macOS.

ok, then as is... the current formula will install and work as expected, and will warn/notify the user if they already have the other spin installed.

from tailspin.

bensadeh avatar bensadeh commented on August 24, 2024

Thanks again @LaurentFough , really appreciate how quickly you managed to put this together πŸ™

from tailspin.

LaurentFough avatar LaurentFough commented on August 24, 2024

Thanks again @LaurentFough , really appreciate how quickly you managed to put this together πŸ™

I wanted to test on macOS, so no worries & You're welcome.

from tailspin.

LaurentFough avatar LaurentFough commented on August 24, 2024
  • Added Homebrew/tap installation instructions as well.

from tailspin.

bensadeh avatar bensadeh commented on August 24, 2024

Thank you again @LaurentFough . Merged in #56 .

from tailspin.

 avatar commented on August 24, 2024

Honestly, I don't think this how homebrews tap system is meant to work. My suggestions were completely ignored. Also is there any automation for a version bump/update?

from tailspin.

 avatar commented on August 24, 2024

Oh neat!

brew uninstall tailspin
brew untap bensadeh/tailspin
brew update
brew install tailspin

works!

from tailspin.

bensadeh avatar bensadeh commented on August 24, 2024

Great, I will update the readme with the changes. Thanks for helping with the tap in the meantime @LaurentFough . Sorry your tap couldn't be used more, but it is easier for me to let the formula from core be maintained and updated there.

from tailspin.

LaurentFough avatar LaurentFough commented on August 24, 2024

Honestly, I don't think this how homebrews tap system is meant to work. My suggestions were completely ignored. Also is there any automation for a version bump/update?

@qa-alexander-eimer That actually is how taps are supposed to work.
For 3rd-Party taps, anyway - the only missing ingredient was the provision of a homebrew-tailspin repo.
Everything else was compliant with Homebrew recommendations.

@bensadeh No worries; I prefer the submission to Homebrew-core as well.

If you're going to create an automation for release updates, let me know.

from tailspin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.