I got this when decompressing a deflate-encoded response from <a href="http://baike.ba

Here's what I've changed: <div class="highlight highlight-source-diff notranslate

deflate decompress error about http-parser HOT 4 CLOSED

lilydjwg commented on August 20, 2024

deflate decompress error

from http-parser.

Comments (4)

benoitc commented on August 20, 2024

can you provide a patch?

from http-parser.

benoitc commented on August 20, 2024

mmm in deflate, you shouldn't get a gzipped response which is all the point of 16+zlib.MAX_WBITS . Maybe smth wrong in the way they handle deflate.

from http-parser.

lilydjwg commented on August 20, 2024

Here's what I've changed:

diff --git a/http_parser/parser.pyx b/http_parser/parser.pyx
index 4ec9481..835842c 100644
--- a/http_parser/parser.pyx
+++ b/http_parser/parser.pyx
@@ -109,7 +109,7 @@ cdef int on_headers_complete_cb(http_parser *parser):
             res.decompressobj = zlib.decompressobj(16+zlib.MAX_WBITS)
             del res.headers['content-encoding']
         elif encoding == 'deflate':
-            res.decompressobj = zlib.decompressobj()
+            res.decompressobj = zlib.decompressobj(-zlib.MAX_WBITS)
             del res.headers['content-encoding']
         else:
             res.decompress = False

It seems there are two kinds of deflate in real world^link. I wonder if there is any chance to handle them both?

from http-parser.

benoitc commented on August 20, 2024

Maybe a better fix would be to check if an exception is raised the first time we add some data and recreate the object . I will propose a patch later today.

from http-parser.

Recommend Projects