Lots of fwrite warnings in the latest version about routeros-api HOT 13 CLOSED

@BenMenking Just want to say thanks for this lib it saves my life

from routeros-api.

Looking at those lines, I'm suspecting that the socket is no longer valid (possibly false). Ideally we would check for socket validity before the fwrite() and then handle any errors appropriately at that point.

Another possibility is that connect() was not called before write() is being called. Regardless, write() should check for a valid socket and protest much if invalid.

from routeros-api.

I just realized that I was connecting to the wrong IP. In this case we were never able to connect at all... so we should add some tests that look for:

if (!$this->connected) {
    return false;
}

Before each call to read/write?

from routeros-api.

Well, as I've been thinking about this, I'm wondering if we should also change connect() to only attempt once instead of multiple times. Let the caller of connect() handle errors, which more than likely can't be fixed by multiple attempts.

Adding a socket validity check should be done. Represent errors in the form of exceptions?

from routeros-api.

Additionally, connect() should have returned false which the calling needs to trap and handle. Maybe use an exception so it's pretty clear there was a fatal error.

from routeros-api.

I agree with everything you said. It's my fault for not handling connect() properly... but the library should also not toss a bunch of warnings if things go haywire.

from routeros-api.

Fully agree. I'll see what I can do here in the next hour or so.

from routeros-api.

For what it's worth... we've got over 1000 hEX's deployed now and we use this library to talk to all of them. It works great!

from routeros-api.

Great to hear! Maybe we can make some good incremental improvements during 2017 too :)

from routeros-api.

Now that we're relying on it more I'm sure I'll have some pull requests for you this year.

from routeros-api.

I've made those changes in branch better-error-handling so you can test them out. Didn't go as far as adding in exceptions right now.

from routeros-api.

I don't think you pushed that branch. I'm not seeing that on my local repo, or on Github.

from routeros-api.

It's there now. Had to find my laptop :)

from routeros-api.