Comments (8)
I'm gonna see what can be done about this. Would you be able to test this?
I would propose skipping the step and echoing an appropriate message. Maybe the whole output of the ant build could be revised, it's a little messy right now.
from se-autoreviewcomments.
I can test this but only at irregular intervals. I have access to a couple Mac's for testing but I'm only at that venue a day or two a week.
I havn't tried compiling the binary myself from the Github project myself yet. There is some chance that might work (and we could even bundle it). In any case there must be another CRX signer that works on OS X.
I think this is pretty low priority though.
from se-autoreviewcomments.
#27 could be a temporary solution. Would be cool if you get around to checking it :)
from se-autoreviewcomments.
Unfortunately something is amiss. From OS X:
chrome-crx:
BUILD FAILED
/Users/caleb/projects/SE-AutoReviewComments/build.xml:264: echo doesn't support the "if" attribute
from se-autoreviewcomments.
Stupid copy&paste mistake. The if="isMac"
is not even needed, even if it would work. I'll fix it when I get home.
from se-autoreviewcomments.
Ok. My next test opportunity will be WE so no rush. I should have a few minutes to actually play with it and fix it if anything else is broken when I test. I'll also try to compile that thing and see if we can't get a matching OS X binary that works.
from se-autoreviewcomments.
I fixed the if
attribute in https://github.com/oliversalzburg/SE-AutoReviewComments/tree/fix-crx-osx
from se-autoreviewcomments.
That fix works (and I re-opened and merged the pull request into devel).
However it seems like this should be actually fixable. I couldn't get buildcrx to compile, but the upstream project suggests it should work. I think I have an issue with mix-and-match architectures in the installed libs on this Mac. I'll keep trying to sort it out.
from se-autoreviewcomments.
Related Issues (20)
- remote not working on Firefox developer edition with user-script HOT 1
- "auto" button appears in wrong spot on sites with responsive design HOT 2
- Reduce code complexity by piggybacking the "welcome" check based on whether or not the "new contributor" indicator is visible HOT 1
- Default welcome message references incorrect variable for site name HOT 9
- Add a way to insert the name of the poster into the welcome text and the auto comments. HOT 4
- How do I restore lost auto comments? HOT 4
- Bug with welcome message and markdown HOT 2
- Auto link suddenly disappeared today from Chrome 72 HOT 15
- Script seems to have completely broken just now HOT 1
- "Auto" link not apperaing anymore HOT 2
- 'auto' link doesn't show anymore HOT 1
- Extension has stopped working HOT 5
- Welcome message not inserted HOT 2
- Force welcome does not work anymore HOT 1
- Dark theme Support HOT 3
- [Feature Request] Syncing HOT 7
- Can the userscript's Local Storage data be put into a single property, rather than 30 or more separate ones? HOT 2
- Use magic links instead of //$SITEURL$/some-resource when possible?
- Use the close vote reason as they would appear "From review"? HOT 1
- Not all question-related comments are showing in UI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from se-autoreviewcomments.