Fix build on OS X about se-autoreviewcomments HOT 8 OPEN

I'm gonna see what can be done about this. Would you be able to test this?

I would propose skipping the step and echoing an appropriate message. Maybe the whole output of the ant build could be revised, it's a little messy right now.

from se-autoreviewcomments.

I can test this but only at irregular intervals. I have access to a couple Mac's for testing but I'm only at that venue a day or two a week.

I havn't tried compiling the binary myself from the Github project myself yet. There is some chance that might work (and we could even bundle it). In any case there must be another CRX signer that works on OS X.

I think this is pretty low priority though.

from se-autoreviewcomments.

#27 could be a temporary solution. Would be cool if you get around to checking it :)

from se-autoreviewcomments.

Unfortunately something is amiss. From OS X:

chrome-crx:

BUILD FAILED
/Users/caleb/projects/SE-AutoReviewComments/build.xml:264: echo doesn't support the "if" attribute

from se-autoreviewcomments.

Stupid copy&paste mistake. The if="isMac" is not even needed, even if it would work. I'll fix it when I get home.

from se-autoreviewcomments.

Ok. My next test opportunity will be WE so no rush. I should have a few minutes to actually play with it and fix it if anything else is broken when I test. I'll also try to compile that thing and see if we can't get a matching OS X binary that works.

from se-autoreviewcomments.

I fixed the if attribute in https://github.com/oliversalzburg/SE-AutoReviewComments/tree/fix-crx-osx

from se-autoreviewcomments.

That fix works (and I re-opened and merged the pull request into devel).

However it seems like this should be actually fixable. I couldn't get buildcrx to compile, but the upstream project suggests it should work. I think I have an issue with mix-and-match architectures in the installed libs on this Mac. I'll keep trying to sort it out.

from se-autoreviewcomments.