Git Product home page Git Product logo

Comments (4)

JakeCigar avatar JakeCigar commented on September 3, 2024 1

Thanks to your issue, my issue was solved by using esprima-next!

I just did
npm install esprima-next
and coded
recast.parse(code,{ parser: require("esprima-next") })

from recast.

btiernay avatar btiernay commented on September 3, 2024 1

It's definitely much better, but still fails for certain things like private class fields. This is more of a failing of ast-types than Recast, but Recast needs to change in a few areas:

  1. The parser is hard coded to esprima in certain parts of the code
    // Use ast.tokens if possible, and otherwise fall back to the Esprima
    // tokenizer. All the preconfigured ../parsers/* expose ast.tokens
    // automatically, but custom parsers might need additional configuration
    // to avoid this fallback.
    var tokens = Array.isArray(ast.tokens)
        ? ast.tokens
        : require("esprima").tokenize(sourceWithoutTabs, {
            loc: true,
        });

The above would need to be updated to support esprima-next.

  1. ast-types needs to be extended by so-called "forks" to support then new syntax elements: #1283

from recast.

eventualbuddha avatar eventualbuddha commented on September 3, 2024

Out of curiosity: why not use @babel/parser? Also, what specifically fails when using esprima-next? Do you have a code sample? This works fine for me and has ast.tokens, so it shouldn't be falling back to esprima's tokenizer:

import { parse } from "recast";
import * as esprima from "esprima-next";

const code = `ITEM?.getAsEntry?.() ?? ITEM?.webkitGetAsEntry?.()`;

console.log(parse(code, { parser: esprima }));

from recast.

btiernay avatar btiernay commented on September 3, 2024

Out of curiosity: why not use @babel/parser?

Originally it was because I needed something that could be bundled small enough to fit within Snowflake's constraints. I tried with Babel and it was too large, but I have since taken a different approach.

Also, what specifically fails when using esprima-next? Do you have a code sample? This works fine for me and has ast.tokens, so it shouldn't be falling back to esprima's tokenizer:

import { parse } from "recast";

import * as esprima from "esprima-next";



const code = `ITEM?.getAsEntry?.() ?? ITEM?.webkitGetAsEntry?.()`;



console.log(parse(code, { parser: esprima }));

It was the PrivateName it was returning instead of PrivateIdentifier for class private fields. I've opened an issue against esprima-next since.

from recast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.