Git Product home page Git Product logo

Comments (2)

benjamine avatar benjamine commented on August 17, 2024

Hello,
what objectHash function are you using?
From what I can see, the items in those array have no way to be matched (ie. how can jsondiffpatch detect which elements in the original array corresponds to which element in the final array?

if objectHash function returns different hashes for all elements on both sides, then you get all deleted, and all inserted.

In other words, to get nested diff in your array items, you need them to be matchable by objectHash. the simplest option is having an "id" field.

As a test I added "id" fields to all items on your example, try pasting these on the DEMO page to see the result:
(the objectHash function at DEMO page considers an id field if found, but you can use anything else)

{
  "a": "A",
  "num": 3,
  "projects": [
    {
      "id": 1,
      "arr": [
        {
          "id": 1,
          "h": "h",
          "arr2": [
            {
              "id": 1,
              "metadata": {
                "names": true
              },
              "names": [
                "name1",
                "name2"
              ]
            },
            {
              "id": 2,
              "metadata": {
                "names": true
              },
              "names": [
                "name1",
                "name2"
              ]
            }
          ]
        },
        {
          "id": 2,
          "h": "h2",
          "arr2": [
            {
              "id": 1,
              "metadata": {
                "names": true
              },
              "names": [
                "name3",
                "name4"
              ]
            },
            {
              "id": 2,
              "metadata": {
                "names": true
              },
              "names": [
                "name3",
                "name4"
              ]
            }
          ]
        }
      ],
      "obj": {
        "visible": false
      },
      "str": "str"
    }
  ]
}
{
  "a": "B",
  "num": 4,
  "projects": [
    {
      "id": 1,
      "arr": [
        {
          "id": 1,
          "h": "h",
          "arr2": [
            {
              "id": 1,
              "metadata": {
                "names": true
              },
              "names": [
                "name1 & name 0",
                "name2"
              ]
            },
            {
              "id": 2,
              "metadata": {
                "names": true
              },
              "names": [
                "name1 for testing",
                "name2"
              ]
            }
          ]
        },
        {
          "id": 2,
          "h": "h2",
          "arr2": [
            {
              "id": 1,
              "metadata": {
                "names": true
              },
              "names": [
                "name3",
                "name4"
              ]
            },
            {
              "id": 2,
              "metadata": {
                "names": true
              },
              "names": [
                "name3",
                "name4 being tested"
              ]
            }
          ]
        }
      ],
      "obj": {
        "visible": true
      },
      "str": "str2"
    }
  ]
}

from jsondiffpatch.

Keyamoon avatar Keyamoon commented on August 17, 2024

Thanks for the clarification. I was assuming the objectHash function would only be used at the leaves (objects with no arrays or other objects as their members). Since I can't add IDs to my objects, I came up with a different objectHash which seems to work better for me.

jsondiffpatch.config.objectHash = function(obj) {
    var hash = [],
    prop;
    for (prop in obj) {
        if (obj.hasOwnProperty(prop)) {
            hash.push(prop);
        }
    }
    return hash.sort().join('');
};

from jsondiffpatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.