Causes app to break if Stripe not loaded about angularjs-stripe HOT 4 CLOSED

handle the error if it can't

How? Swallowing errors (or printing to the console or any other option) is even worse for a lot of people.

Since this package is basically just boilerplate and a call to stripe-as-promised, I've generally said no to "advanced" features or anything else that serves a minority of users.

from angularjs-stripe.

By 'handle the error', I mean that it shouldn't kill the entire app, and could perhaps expose a 'errorLoadingStripe' variable similar.

To replicate what I'm talking about, take out the stripe.js <script> tag in one of your pages and see what happens. The same would happen if the Stripe site goes down.

Not too worried if you fix it as I've now handcranked, but thought I should raise the issue :)

from angularjs-stripe.

Yup, I totally know what you mean, but would prefer to stick to more aggressive behavior for now to keep things simple.

Check out the code—you can get the promisification bits from stripe-as-promised with almost no effort. You can go as deep as you want (lazy loading, error handling, etc.) while still retaining the same interface.

from angularjs-stripe.

In that case, you should really add a warning to the front page:

Warning: This component is not production ready. If you use this component and the Stripe JS file fails to load for any reason at all, your app will no longer work.

(though honestly, I think it's a huge bug to simply close in the name of the keeping things simple!)

from angularjs-stripe.