Event handler and arguments about react-redux-grid HOT 6 CLOSED

Honestly, this is a little sloppy on my end. Rather than applying the arguments to the HANDLE_CELL_CLICK and the HANDLE_CELL_DOUBLE_CLICK events, I'd rather pass them an explicit set of args.

This is also something I'd like to standardize across all grid events in the future. Since making these changes is breaking, I'd prefer to make all the changes at one time, and release them as a new major.

Do you have a preference for how you'd like to see event arguments composed?

I think we would have to load a lot of metadata for each call since many events are context specific, but they could be undefined if they weren't available at scope.

HANDLE_SOME_EVENT = ({ 
    editor,
    events,
    isSelected,
    row,
    rowId,
    rowIndex
}, browserEvent) => {};

Ideally, every event function would have this shape. Is there anything else you'd like to see added?

Again, since this is a breaking change, I propose getting this work done in a feature branch and merging as a new major release. Are you currently broken, or can you work with what is currently there?

from react-redux-grid.

Definitely not breaking/blocker for me at the moment, I just stumbled across it while looking over function signatures in the documentation and noticed some inconsistencies.

from react-redux-grid.

Is there anything missing from that function call that you'd like to see?

from react-redux-grid.

LGTM 👍

from react-redux-grid.

Proposed implementation:

export const handleEvent = (name, events, context = {}, browserEvent) => {
    if (!events || typeof events[name] !== 'function') {
        return;
    }

    events[name]({
        editor: context.editor,
        events,
        isSelected: context.isSelected,
        row: context.row,
        rowId: context.rowId,
        rowIndex: context.rowIndex
    }, browserEvent);

};

from react-redux-grid.

All grid event handlers now accept the same shaped arguments. Releasing as new major.

from react-redux-grid.