Git Product home page Git Product logo

Comments (2)

bencripps avatar bencripps commented on May 29, 2024

I've seen this use case with other grid components in the past. And I think it makes sense here. But rather than have a consumer pass in props to be added as attributes to the row, I think it makes most sense to create a rowRenderer, similar to how the column renderer works.

That way you could control the entire HTML structure of the row. Initially, I think it could look something like this.

const gridProps = {
    dataSource,
    columns,
    stateKey,
    rowRenderer: ({ children, row }) => {
        // children are the react cells, that will be computed by grid
        return (
            <tr class='my-custom-class' key={ row.symbol }>
                { children }
            </tr>
        );
    };
};  

const grid = <Grid { ...gridProps } />;

There are a few caveats to this approach:

  1. It's up to the developer to ensure proper HTML structure. React will not allow the row component to be anything but a <tr>, and will throw an Invariant Violation if another DOM type is passed. (I think that's ok, the error will be explicit).
  2. It's up to the developer to pass the children prop down, otherwise the cells will not be rendered. (Again, I'm ok with that).

Let me know your thoughts. Thanks!

from react-redux-grid.

kayazinc avatar kayazinc commented on May 29, 2024

I think the solution that you provided above is great. This component has fulfilled all of the functionalities that I required. Thanks again @bencripps.

from react-redux-grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.