Comments (2)
I've seen this use case with other grid components in the past. And I think it makes sense here. But rather than have a consumer pass in props to be added as attributes to the row
, I think it makes most sense to create a rowRenderer
, similar to how the column renderer
works.
That way you could control the entire HTML structure of the row. Initially, I think it could look something like this.
const gridProps = {
dataSource,
columns,
stateKey,
rowRenderer: ({ children, row }) => {
// children are the react cells, that will be computed by grid
return (
<tr class='my-custom-class' key={ row.symbol }>
{ children }
</tr>
);
};
};
const grid = <Grid { ...gridProps } />;
There are a few caveats to this approach:
- It's up to the developer to ensure proper HTML structure. React will not allow the
row
component to be anything but a<tr>
, and will throw anInvariant Violation
if another DOM type is passed. (I think that's ok, the error will be explicit). - It's up to the developer to pass the
children
prop down, otherwise thecells
will not be rendered. (Again, I'm ok with that).
Let me know your thoughts. Thanks!
from react-redux-grid.
I think the solution that you provided above is great. This component has fulfilled all of the functionalities that I required. Thanks again @bencripps.
from react-redux-grid.
Related Issues (20)
- how to refresh with remote dataSource from another action HOT 2
- Custom look of GRID_ACTIONS elements
- Assigning a property of sortable: true and defaultSortDirection: ASC|DESC does not sort the table by default HOT 1
- EditorActions.addNewRow documentation or sample code HOT 2
- Align header columns with table's contents HOT 2
- Nested Grids using react-redux-grid
- Nested object property as column value HOT 2
- PropTypes (oneOf) error when loading the Grid
- Include react-redux-grid in existing project where also uses HTML5 backend causes problem.
- Include react-redux-grid in existing project where also uses HTML5 backend causes problem. HOT 1
- Unable to remove "Edit" item from grid actions HOT 2
- Is there a way to prevent a node from moving? HOT 3
- Pass store to Grid HOT 3
- incorrect selection of indexes when selecting row
- Is there a way to add custom edit/delete button?
- too small select checkbox
- @types/react-redux-grid HOT 1
- rowIndex in tree mode
- Tree, selection throwing an mutation exception on action @@react-redux-grid/SET_SELECTION
- Instead of disabling actions can we hide it from the the action menu? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-redux-grid.