Limit Query in Post resolver : limit instead of take about lireddit HOT 4 OPEN

You, my friend, are a lifesaver. I was hesitant on trying Ben's solution on using raw SQL for joining and then mapping the values using json function, but since this works it has saved me hours. Many thanks.

from lireddit.

I think there is still a bit more optimization that could be done here. For example, this will always join the post and user table, even if the query didn't ask for the creator fields. In that case, checking the info object to see if the query contains the creator field and only joining it would be better.

from lireddit.

Thank you! This is great, I thought having to write SQL was a bit more effort and assumed it could have been achieved with the queryBuilder

Although, I think;

qb.limit(realLimit);

should be

qb.limit(realLimit + 1);

and in the return

return {
  posts: posts.slice(0, realLimit),
  hasMore: posts.length === realLimit + 1,
};

Or instead of realLimit + 1 use the variable reaLimitPlusOne

For the hasMore functionality to work correctly.

from lireddit.

Possible solution typeorm/typeorm#747 (comment)

from lireddit.