Comments (1)
Also, looking at builds_controller.rb for Github commit hook it looks like it just checks that the token is correct than builds the project. Which will be a problem when you have several branches.
I understand that there is a need for "better" branch treatment in Bennett but just enhancing the builds_controller.rb to honor the "ref" parameter in the JSON payload from Github and make sure that the ref is the same as the projects configured branch. Then one could set up different projects for different branches and all of the commit hook urls for bennett to github, then all would get triggered when a commit occurs but only the project with corresponding branch would get triggered to rebuild.
from bennett.
Related Issues (20)
- Suggest default commands
- Support other commands than test commands
- Feedback button on top of content
- show errors if login fails HOT 1
- Automatic login after signup
- Request build button should refresh table HOT 1
- Zombie workers HOT 1
- Better workers management
- Provide a dynamic status badge
- Refresh on project is cached by cloudflare HOT 1
- Visual bug: "Delete" buttons not aligned when adding a command
- Refactor CSS
- protected emails in the admins view HOT 3
- Cant clear a stuck build HOT 6
- Worker falls over on locked database HOT 11
- Can't compile assets
- root_url defaulting to subdomain rather than full host name HOT 2
- Ruby 2.0 HOT 14
- Redis 2.6.16 config issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bennett.