Comments (7)
I think as a first pass it'll be okay to sort the data into the suggested format. This will cover 90% of use cases. In the future, we can take a look at flattening it again into a dedicated database. The only other option would be to repeat the data in different formats.
from swiftyguitarchords.
On the last day of October; here are my comments/suggestions.
First of all; the database should be manageable. I was missing 'G#' and find-out there was a 'Fb'. The are the same, but not realy. Just almost. Altered the JSON file to add it...
Of course not a very pleasant experience; hacking a file.
So, I wrote a quick and dirty macOS Ventura application to manage the database.
https://github.com/Desbeers/Chords-Database
One step at the time.
Please have a read at the README.
from swiftyguitarchords.
This is amazing and perfect for this project. wow!
We should update the readme here to link to it.
Giving me more ideas too.
I wonder if we should also add a way to play those midi sounds!
This is so cool.
from swiftyguitarchords.
If you get the PR up for the addition of those chords, will gladly merge that in for you.
from swiftyguitarchords.
Thanks, it was fun to make! The app is a bit rough and has a few extensions to SwiftyChords to get the job done. I would really like to have them in your package instead. Once it's a bit cleaner app I can send it as PR. Ideal, it should be part of your package instead of a separate item in another GitHub account.
It also gave me a few ideas:
- Yes, play the midi sound, that would be cool!
- Add the keys at the bottom of the diagram
- Calculate the 'barres'? Then chord definitions are truly compatible with a ChordPro {define} and that can be used as unique ID
I send a PR with the first pits and pieces.
from swiftyguitarchords.
It can play a chord with MIDi now, so cool!
It sounds a bit artificial, to be honest, but that's MIDI.... You can select your kind of 'instrument'; some are better than others...
from swiftyguitarchords.
Excellent! I'll check it out!
from swiftyguitarchords.
Related Issues (10)
- Populating json file HOT 1
- Add support for ♭ , ♯, ², °, etc symbols. HOT 1
- Localization
- Checks for Sharp/Flats/Maj/Min etc HOT 1
- Ability to specify Chord Name display type in the drawing function
- Different Tunings
- Update chord charts remotely
- Add Support for Ukulele HOT 1
- Namespace needs updating to support Ukulele HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftyguitarchords.