Read bytes size from results about beaneater HOT 5 CLOSED

+1
Use telnet is not correct. Need to read a specified number of bytes.

from beaneater.

I forked this tonight in order to not only fix that issue, but also make it 8-bit clean as Net::Telnet will interpret things that look like Telnet command options etc. and so will barf on a lot of binary data. The easiest way for me was ripping out Net::Telnet and replacing it with raw TCPSockets. I also have corrected a few test cases that didn't take the correct length into account.

My commits are here: https://github.com/vidarh/beaneater/commits/tcpsocket

I've not opened a pull request for it yet because I had to comment out some of the test cases that strangely hang for me (it doesn't seem to like mocking TCPSocket), but I'd love any comments and would be happy to help adapt it if you're interested in considering merging it.

from beaneater.

Yeah I would agree we have to rip out Net::Telnet and replace with TCPSockets. Your commits look great, that's what I expected we would want to do. Definitely interested in merging it if you can get the pull request prepared. Thanks!

from beaneater.

Great. I'll prepare a pull request.

from beaneater.

I'm closing this issue, it's fixed here #19

from beaneater.