Git Product home page Git Product logo

Comments (8)

mdujava avatar mdujava commented on August 25, 2024

Panic detection can be configured by PANIC_REGEX, it's set on LC basis

PANIC_REGEX = "Kernel panic|Oops[\s:[]|general protection fault(?! ip:)|general protection handler: wrong gs|\(XEN\) Panic|kernel BUG at .+:[0-9]+!"

and by default it includes Oops.

You can disable panic detection all together by including <watchdog panic="None"/> in your recipe.

from beaker.

bgoncalv avatar bgoncalv commented on August 25, 2024

Note, I don't want to ignore Oops in general. My only problem are with Oops that happened on provision that causes the last task in the recipe to be marked as Panic, this task shouldn't be marked as panic as there was no Oops when the task executed.

from beaker.

StykMartin avatar StykMartin commented on August 25, 2024

@bgoncalv is right. I'm aware of this behavior. The problem is that we can't really mark Panic during installation at this moment, therefore most of the time it lands on the first task. But, it may happen that we failed to detect it at first therefore it will land on another (the one which was running when we found Panic).

Yeah. This needs to remain open and we will need to find a better way how to manage this.

from beaker.

bgoncalv avatar bgoncalv commented on August 25, 2024

Thanks @StykMartin, do you have any suggestion how can we workaround this? For example, we could create a dummy task to trigger this panic detection and run it as first task. Is there a way for a task force to run the detection?

from beaker.

StykMartin avatar StykMartin commented on August 25, 2024

Hello @bgoncalv. My answer never ended on GitHub. I'm sorry about that. So the situation is quite a bit more complicated, but I feel like we can make some compromise if you still need it.

So panic detection is running on background in each region. Then it is proxied to the main server to process. The main server will check tasks assigned to given recipe and iterate over. If iteration is exhausted we will mark last item - because that's what will end up in variable.

If you have any idea how we can help you @bgoncalv to make it saner feel free to shoot.

from beaker.

bgoncalv avatar bgoncalv commented on August 25, 2024

@StykMartin thanks for the reply. Indeed that feature would be helpful for us. If the panic detection will assign panic detected during provision always in the last task of the recipe that would help us indeed.

from beaker.

StykMartin avatar StykMartin commented on August 25, 2024

This is happening at this moment. All panics are assigned to the last task if there is no running task. So basically if we didn't register any start (for example provisioning) we will always mark last.
However, there is a catch. If restraint will report n-2 task as finished and n-1 is not reported as started then we may report panic in this window to last as well. But changes are quite small that restraint will crash in moments like this.

from beaker.

StykMartin avatar StykMartin commented on August 25, 2024

I would suggest you put dummy tasks at the end and then collect panics from there.

I will try to redesign this feature so we can report panics during provisioning to dedicated space and not marking tasks.

from beaker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.