BigScreen.Enabled Not Correctly Set in Safari 5.1.x about bigscreen HOT 5 OPEN

With this fix, the only way I can get iframe content to truly go into full screen is to add the "webkitAllowFullScreen" property to the iframe. "allowfullscreen" is not enough.

Example:

<iframe src="{WEBPAGE_WITH_BIGSCREEN_STUFF_HERE}" allowfullscreen webkitAllowFullScreen></iframe>

That's the only way I can get it to work. webkitAllowFullScreen must be added to the iframe.

from bigscreen.

I think this is actually by design. BigScreen.enabled should only be true if calling BigScreen.request would actually work. If you don't have webkitallowfullscreen added to the iframe, that request won't work.

If all you're interested in is doing fullscreen for a video (which is most of the reason this library exists), BigScreen.videoEnabled(video) is there to check for that. There's an older fullscreen api that works only on videos that is enabled even if the iframe lacks the fullscreen attribute.

from bigscreen.

No, in my case, I want the body of the entire HTML document in the iframe to go fullscreen. Without my changes, it won't go fullscreen in Safari when there is no reason for it to NOT go into fullscreen.

Basically, it should go fullscreen since it works just fine, but BigScreen.enabled is false until my changes are made due to checking a property that doesn't exist on the dom in an iframe.

from bigscreen.

Can you make a CodePen or JSFiddle that shows that it works? The fullscreen request should fail without the webkitallowfullscreen attribute on the iframe.

from bigscreen.

Please test the attached HTML file in all browsers. When you click on the image in each iframe, the image should go fullscreen. Try it in Safari. When you click on the first image in the iframe, the image does not go fullscreen. The bottom iframe works as expected which contains the changes I made to BigScreen.js

This issue is not related to having the "webkitAllowFullScreen" attribute present on the iframe. It is however required to get it to work with my changes.

test_in_safari.zip

from bigscreen.