Git Product home page Git Product logo

Comments (2)

bcherny avatar bcherny commented on May 29, 2024

This is a pretty unfortunate change in the spec. It means that the meaning of items is dependent on the version of JSON-Schema you use. But since a JSON-Schema is not required to specify its version, this leaves the interpretation of items ambiguous in practice 🫤.

A middle of the road approach to support this without breaking others' code may be to expose the new behavior behind a switch, say --json-schema-version=2020-12. We would check the option in the normalizer, and normalize prefixItems to items and items to additionalItems if needed.

Want to give this a shot?

from json-schema-to-typescript.

TheoAnastasiadis avatar TheoAnastasiadis commented on May 29, 2024

I thought I'd have a go at it.

Added a CLI argument as "--usePrefixItems" which defaults to false, I did not think specifying JSON schema spec version would be helpful at this point since only this version would be supported.

The main addition is a new normalizer rule; renaming the schema keys.

schema.additionalItems = schema.items
schema.items = schema.prefixItems
delete schema.prefixItems

I created a simple unit test as well. I will let it sink in cause maybe more test cases might be needed. I had difficulty understanding the E2E testing setup, so I did not add any new E2E tests, maybe if somebody would very briefly walk me through I am going to do so. Tests are passing, for now.

from json-schema-to-typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.