cluster coverages on by default about smk HOT 4 CLOSED

was previously implemented as:

from smk.

In version 1.0.5, clusterOption.showCoverageOnHover is false by default. I reviewed our code and we set a default value of false in smk.js (https://github.com/bcgov/smk/blame/375e57ec506dbf097a587c443725d032797b54b0/src/smk.js#L729).

from smk.

In further testing, I do see that a vector layer's clustering shows coverage on hover when no clusterOption.showCoverageOnHover value is set in smk-config.json. I'll reopen this while I investigate further.

from smk.

I have a better understanding of this now. My observation of coverage on hover in my last comment was affected by local changes I was making (for bcgov/smk-cli#63) that I didn't think would be related but were a cause.

We set viewer.clusterOption.showCoverageOnHover to false by default in smk.js when we are setting up the structure of the configuration in setupGlobalSMK(). In layer-vector-leaflet.js, in the clusterOptions() function, we then create and populate cluster options. Then when we consume these options in marker-cluster-1.0.6.js, if we haven't specifically set a value, a default of 'true' is used.

layer-vector-leaflet.js was amended to set a value in the options based on the value of showCoverageOnHover, either from the 'viewer' section of smk-config.json, or using the default 'false' set in smk.js. This was fixed in #104, and I've confirmed in local testing that showCoverageOnHover is false unless specifically set to true in smk-config.json in the 'viewer' section.

from smk.