Git Product home page Git Product logo

Comments (3)

amanji avatar amanji commented on June 14, 2024

Wondering if we can retire the inactive search URL parameter. Here are my thoughts:

  • This is not a generic Aries-VCR or credential concept, however the logic is embedded within Aries-VCR and the generic search interface.
  • We can still query and filter for active/historical entities through the application of entity_status category filters. Especially in light of the changes to filtering we want to make that successively expand the result set as filters are applied.

Thoughts on this?

from orgbook-bc-client.

ianco avatar ianco commented on June 14, 2024

Active/Historical refers to the company status (whether the company is currently "Active" according to BC Registries - it can become historical if for example the company fails to file their annual report for 2 years)

Inactive refers to the credential itself, for example if a new credential was issued due to a company name change then the previous credential becomes "inactive". (The company itself will still be "Active", and both credentials will show this status, however the most recent credential will be "active" and then prior one "inactive".

I think it's useful to retain this search parameter, but I think the concept will be confusing for end users.

from orgbook-bc-client.

amanji avatar amanji commented on June 14, 2024

We may be conflating a credential that was revoked (i.e. has expired) vs a company that is Active/Historical in the context of BC Registries. The former is mapped to the revoked query parameter, the latter is mapped to the inactive query parameter. The two query parameters, in general, create confusion as to what they refer to. So my suggestion is we retain one or the other; the parameter we choose to keep would map to whether a credential is active (i.e. has not expired) vs it corresponding to a company status. Company status could instead be toggled using the category filter: entity_status, since it is already stored/indexed as a category attribute along with entity_type and other categories.

My general preference would be to remove the inactive parameter since it is very context-specific to BC Registries yet it is part of the core Aries-VCR search logic.

from orgbook-bc-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.