Git Product home page Git Product logo

Comments (4)

pripley123 avatar pripley123 commented on September 23, 2024

Testing failed in test environment (used the search term "word" (there are multiple requests on page 2 with that word in them). Moving back to backlog.

from ocwa.

Jonesy avatar Jonesy commented on September 23, 2024

@BrandonSharratt Paul and I looked into this and it looks like the problem is that the name parameter will only return a hit if it's an exact string match with a request in the database. I propose we keep this functionality on the name parameter so I can check if a request name is available, but add a search parameter that does more of a traditional search that returns possible matches.

from ocwa.

BrandonSharratt avatar BrandonSharratt commented on September 23, 2024

I have added search functionality to the existing endpoint.

if you append a * character to your search criteria (note append) it will do an insensitive regex search (contains) so it effectively applies a * to both sides of your search. If you do not append the * the functionality will be as it currently is.

Therefore when searching you could append a * for the user and not when you want to get a specific request by name

from ocwa.

pripley123 avatar pripley123 commented on September 23, 2024

This one is going to be inconvenient to verify in the test environment since we've cleared out all old requests. That said, search did appear to behave as expected (with only one page of requests). I did notice if you add a "*" to the front of a query you get some weird behaviour - a blank screen - however, not something we need to resolve for MVP.

from ocwa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.