Rule "studyid_not_in_content" should gracefully pass when unable to read incoming file about ocwa HOT 5 CLOSED

Rule was updated to print(not bool(re.compile(b'[\\w]{1}[\\d]{9}').search(${file.content}))) which handles binary content better and satisfies this issue.

from ocwa.

tried creating a new request in the test environment and uploaded a jpg. Saved and closed. Viewed the request. Still flagged for study ids

from ocwa.

I've tried a couple of more jpg - these are passing ... so I need to narrow this down a bit

from ocwa.

Certain image files have an explicit string inside the binary which will trip the [\w]{1}[\d]{9} regex rule as it only looks for either

1. a letter followed by exactly 9 digits or
2. exactly 10 digits

The implemented rule is behaving as expected; however until we are provided better requirements that do not match on so many potential values, some images are inevitably going to fail.

from ocwa.

Thanks for documenting the reason for images failing. Agreed it is expected behaviour for now. Since the regex used to search for study ids is configurable, this seems fine for MVP

from ocwa.