Git Product home page Git Product logo

Comments (12)

chdivyareddy avatar chdivyareddy commented on September 25, 2024

This issue applies to Re-Registration and Corrections as well for legacy registrations:

MHR 030401: Year of Manufacture was not updated yet

image.png

Corrections:
image.png

from entity.

dimak1 avatar dimak1 commented on September 25, 2024

The problem most likely is the the circa checkbox (This Year of Manufacture is approximate). I can take a look.

from entity.

dimak1 avatar dimak1 commented on September 25, 2024

The issue with the legacy registrations is the circa value - It is missing in the response for baseInformation. @doug-lovett

Legacy Registration (eg. 017011):
Screenshot 2024-06-27 at 12.25.09.png

Any Recent Registration (eg. 108364):
Screenshot 2024-06-27 at 12.30.00.png

from entity.

doug-lovett avatar doug-lovett commented on September 25, 2024

@dimak1 For legacy registrations circa has always been conditionally included if a value exists. For many legacy registrations, including 017011, there is no value. The UI should probably treat the absence of a value as equivalent to false, but I will also update the API to set circa to false by default in the next build.

from entity.

dimak1 avatar dimak1 commented on September 25, 2024

Thanks @doug-lovett. If you will update the circa on your end, then UI could stay as is and should handle the badge display. I'll wait for next build and check if UI changes will be needed.

from entity.

dimak1 avatar dimak1 commented on September 25, 2024

Fixed by API update. Ready for QA in DEV.

from entity.

chdivyareddy avatar chdivyareddy commented on September 25, 2024

Verified in DEV for Public Amendment, Correction and Re-Registration.

image.png

from entity.

chdivyareddy avatar chdivyareddy commented on September 25, 2024

Hey @dimak1 , DEV looked good, but in TEST I still see the 'Corrected/Amended' badge for Re-registration, Amendment and Corrections without changing the year of manufacture and the Model value is displayed in the Make field in TEST. Please take a look at the attached screenshots below for DEV and TEST, thanks!

MHR 030381 in TEST

image.png

MHR 030381 in DEV

image.png

from entity.

dimak1 avatar dimak1 commented on September 25, 2024

@chdivyareddy, the fix was made on the API side.

@doug-lovett did we deploy API to TEST?

from entity.

doug-lovett avatar doug-lovett commented on September 25, 2024

@dimak1 no, the API build includes another ticket that has not been tested.

from entity.

chdivyareddy avatar chdivyareddy commented on September 25, 2024

@doug-lovett I'll work on the other ticket and notify in the Assets channel for API deployment, thank you!

from entity.

chdivyareddy avatar chdivyareddy commented on September 25, 2024

Verified in TEST!

image.png

from entity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.