Comments (4)
I think this is a loophole -- if the subject NR is affiliated to the current account then the entered phone/email are not verified.
Should we change the code to always verify the phone/email (even if not needed)? (But we don't know ahead of time if they are needed.) @NaveenHebbale @yuisotozaki
If a change is needed, it's in the Legal API (where the call to validate a name request is handled).
PS Here's an example where the NR is not affiliated to my account, and I entered the wrong phone number:
from entity.
@yuisotozaki Would you be able to express an opinion on this, please?
from entity.
I think the core of this issue is making sure that the user has access of some kind to the NR at the time of filing.
Scenario 1: The user already has access to the NR. I.e. it's in their MBR.
In this case, I would remove the phone/email check entirely at the time the user enter the NR number in the alteration filing.
Scenario 2: An alteration draft was saved with an NR, then the NR was removed from the user's MBR.
In this case, since we don't know if the NR was removed from the user's MBR for security purpose, the safest option is to ask for email/phone in the draft.
Scenario 3: User starts an alteration and adds an NR that is not on their MBR. In this case, we do ask for email/phone to essentially have the user add the NR to their MBR.
from entity.
After discussion with Yui and James, we feel that the current priority is good. This is a loophole but doesn't do anything bad or block the user or allow the user to use the wrong NR; we are simply asking the user for an email/phone that they might not really have to enter, and we might allow the wrong email/phone if the NR is already affiliated. Anyway, probably not a big deal.
A nice solution might be a 2-step process: first prompt for NR number and check it with the API, then if needed prompt for email/phone. This is a medium amount of work but it is in a complex component, for what it's worth.
@OlgaPotiagalova What is your decision on how to proceed with this?
from entity.
Related Issues (20)
- Phase 2: Automated UI tests
- Phase 2: Automated UI Unit Tests
- Phase 2: CI/CD updates
- Phase 2: Review code coverage and sonar cloud setup
- STRR Sprint Objectives Sprint 22.2
- Legal API: continuation in email templates - verify
- Legal API: continuation in email templates - implement
- Add Caching to BTR-API
- Furnishings job - fix broken logging
- UI - MHR with Lien is restricting Staff
- Emailer - fix broken tests
- Emailer - Add letter attachment to stage 1 AR email
- QA Bug : Dissolution Missing for Historical Business in new Dashboard
- Legal API + Dissolutions Job - Add filing_id to batch_processing table
- Legal API: show only application and receipt when status is Rejected HOT 2
- Continuation In - Alteration
- Bug - Change of Director - Data entered lost after date change
- Bug - Incorrect Corp Type text displayed on Correction filing
- PAY-API - CC payment refund/partial refund send bad request to PAYBC_DIRECT_PAY
- Version info
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from entity.