Git Product home page Git Product logo

Comments (20)

LizGovier avatar LizGovier commented on July 30, 2024

Questions for staff

  • Can you open a cancelled home (Yes)
  • can you re-register a cancelled home (Yes)

from entity.

PCC199 avatar PCC199 commented on July 30, 2024

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @doug-lovett

from entity.

LizGovier avatar LizGovier commented on July 30, 2024

This has been reviewed with Scott and is ready for Dev.

from entity.

PCC199 avatar PCC199 commented on July 30, 2024

Please add your planning poker estimate with Zenhub @dimak1

from entity.

doug-lovett avatar doug-lovett commented on July 30, 2024

Here are some MHR numbers for cancelled homes:
088867
088868
088960
089331
089379
089384
089398
089430
089454
089489
089493
089524
089558
089559
089618
089786
090001
090183
090319
090419
090453
090500
090509
090745
090789
091219
092127
092152
092361
092542
092656

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

@LizGovier right now, for Exempt MHRs, one of the conditions to enable 'Re-Register Home' dropdown button is when home location type is not MANUFACTURER or MH_PARK. Would the same condition apply for Cancelled MHRs?

Here are existing conditions to enable 'Re-Register Home' button:

  1. Staff Role
  2. FF enabled: mhr-exemption-enabled
  3. MHR has child residential or non-res exemption
  4. Home location type is not MANUFACTURER or MH_PARK

Please let me know if Cancelled MHRs would have any overlapping conditions. Thanks!

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

@LizGovier @saragunnarsson please approve my request to access figma designs for this ticket (Cancelled MHRs). Thanks!

from entity.

LizGovier avatar LizGovier commented on July 30, 2024

Hey @dimak1 Only staff can re-register a cancelled manufactured home as QS can not add cancelled homes to their MHR Table. So 'Home location type is not MANUFACTURER or MH_PARK' does not apply.

from entity.

LizGovier avatar LizGovier commented on July 30, 2024

@dimak1
As per our conversation, because this is a staff only filing and the conditions above were added before transport permits and corrections, the conditions to enable 'Re-Register Home' button are:

  • Staff Role
  • FF enabled: mhr-exemption-enabled
  • FF enabled: cancelled home (not sure what the code is for that)

For re-registration we do not need:

  • MHR has child residential or non-res exemption
  • Home location type is not MANUFACTURER or MH_PARK

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

Thanks @LizGovier I will update the conditions, however we don't have feature-flag for Cancelled Home, so I will omit this, but add the check for Exempt status and Cancelled status.

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

Ready for UXA: https://bcregistry-assets-dev--pr-1907-skxdqt7v.web.app/

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

Merged to DEV.

from entity.

LizGovier avatar LizGovier commented on July 30, 2024

Hey @dimak1
Reviewed both Staff and QS views for Cancelled homes. All looks good and is RFQA.

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

Thanks Liz. Ready in DEV.

from entity.

chdivyareddy avatar chdivyareddy commented on July 30, 2024

@LizGovier @dimak1 , Just want to confirm the Cancelled home registration dropdown in the MHR table for staff account. Currently, it displays 'Non-Residential Exemption' as well, but in the designs I don't see it in DEV. Please take a look, thanks!

image.png

Design:
image.png

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

As per ticket #21421 I removed the conditional check for home location, so the only condition that's left is to check for Staff Role + Exemptions Feature Flag.

from entity.

LizGovier avatar LizGovier commented on July 30, 2024

@dimak1
@chdivyareddy, yes you are correct! Non-Residential Exemption should not be part of the dropdown for a cancelled home.

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

Ok I will update it, thanks!

from entity.

dimak1 avatar dimak1 commented on July 30, 2024

Fixed and merged to DEV.

from entity.

chdivyareddy avatar chdivyareddy commented on July 30, 2024

Verified in DEV!

Staff:
image.png

image.png

image.png

Qualified Supplier:
image.png

from entity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.