MHR Unit Notes about entity HOT 21 CLOSED

All Unit Notes :

• when on the MHR page and click to add a Unit Note, the screen loads to the bottom of the page:

Current Result

Expected Result

from entity.

Date Picker

• Can not select a date in the date picker

from entity.

When a unit note is registered and autoscrolls to the registration in the MHR table, the row does not highlight green.

from entity.

Cancel Unit Note - Unable to File

• When I fill out the cancel note information and click 'Register and Pay' I get an 'Unable to File a Unit Note' modal

• Missing Checkbox for Person Giving Notice

Expected Result (Figma File)

from entity.

Hey @cameron-eyds Unit notes have all been tested. Should I message you when I'm done testing or place this ticket in a specific column?

from entity.

@LizGovier Right on!
I think the sprint backlog works.

from entity.

Hi @LizGovier

• the first issue, the page is scrolled up each time I tried to add the new unit note, so not able to reproduce (see
  below)

• the calendar for expiry/effective date seems to be working s expected (screenshot below)

from entity.

@dimak1

• When adding a unit note, the page scrolls to the top vs reloads which gives the impression that you're on the same page. It should re-load the page like it does with 'Residential Exemption' see examples below.

Current Load
Private Zenhub Video

Expected Load
Private Zenhub Video

• Effective Date is loading as Registration Date in the MHR Table

from entity.

@dimak1 I believe you're still working on this ticket, but I've checked off the issues that have been resolved and found a few extra while testing.

from entity.

@LizGovier yes im working on it still, there are few issues left. Regarding the page load, the loading effect showing up when there are API calls that UI is waiting for (or some other actions that takes a bit longer, hence the loading indicator). It is a single-page applications, so it will be fast and snappy. I can try to add a loading in between the states, but it might not have any effect (because it's so quick to load). Let me know.

from entity.

@LizGovier I've updated Optional Person Giving Notice checkbox for Cancel Note, however, it was not in the original requirement to have the checkbox for this unit note type. cc: @chdivyareddy

from entity.

@LizGovier for issue with the Date in the table row, the 'Dec 21' is actually a created date. Here is what we get from the API:

from entity.

@dimak1 The effective date should only be viewed in the Unit Out and it's output. The date listed in the MHR table should always be the registration date.

from entity.

Hi @LizGovier, i checked the API response, and Dec 21 is coming back as created date.

@doug-lovett could you pls check why Dec 21 (and not Jan 3) is in createDateTime for TAXN notice in the response? Thanks!

from entity.

@doug-lovett @dimak1 There might have been confusion in the beginning when the effective date influenced the expiry date, but that should have been updated with #17809.

from entity.

At this point, in UI we can't do much, let's wait for Doug's response.

from entity.

@dimak1 @LizGovier @mstanton1 I believe we have discussed this before in a status meeting. The short answer is that the desired value will display in the registrations table after data migration.
The registrations table data source is the legacy DB2 database.
The DB2 data model does not have a registration effective date, the modernized PostgreSQL data model does.
For unit note registrations that have an effective date, the effective date and time is the DB2 registration date and time. This logic follows the legacy application. The registration timestamp in DEV DB2 for the 107945 TAXN registration is 2023-12-21 00:00:00.0. The value submitted to the API is:
"effectiveDateTime": "2023-12-21T08:00:00.000"

from entity.

Thanks for the reminder @doug-lovett . In this case we can leave it as is and verify post migration that we are showing dates as expected.

from entity.

@LizGovier are we ok to move it to QA?

from entity.

Yes! ready for QA

from entity.

@chdivyareddy fixes have been verified in DEV. Moving this to QA in progress.

from entity.