MHR Land Lease or Ownership about entity HOT 13 CLOSED

@cameron-eyds ready to go

from entity.

Hi @tlebedovich, as I'm working to fix the validation, I noticed there is no error message when the Land Lease option is not selected, which is inconsistent with the rest of the fields. Maybe you want to add one? Because all our required rules have a message to show when something is not entered or selected.

from entity.

@tlebedovich to add to the comment above, I fixed the validation and added an error message when field is required. Let me know if this is ok or needs to be updated (I will not merge until then). Thanks!

from entity.

@dimak1 - I can't see your screenshots attached in this ticket - can you please send them via rocket chat. The validation for the component is shown here: (comps for transfers and registration) https://www.figma.com/file/YcXMXw581zx7YxR34gkKvs/MHR-Transfers-(Phase-1)?type=design&node-id=3356-60935&mode=design

@dimak1 For transfers, the standard error message "< please complete required info..." would also appear under the review and confirm button if this was not completed.

from entity.

@dimak1 , the validation is missing for all the death transfers Land Lease or Ownership component, and in the review screen is automatically displayed 'No' without selecting any radio button. Please take a look, thanks!!

from entity.

@chdivyareddy I can't reproduce, this validation is working ok in DEV.

from entity.

@dimak1 , that's strange, it is still not validating for me in DEV. Please try to fill out all the home owners details before clicking on the review & confirm button. If possible we can have a quick call to reproduce the issue, thanks!!

from entity.

Might* be browser related, we've encountered a few issues that are specific to certain browsers, ie Safari or Mozilla.
Worth lookin into.

from entity.

I was able to reproduce the issue: when all fields (except Land Lease) are filled out, then validation is not working. I will investigate and fix.

from entity.

Hey @dimak1 , just a minor fix for all the Transfer due to death scenarios, if the user selects the Land Lease or Ownership radio button as 'Yes', then in the review screen, the word 'new' should not be displayed (it should only display for sale/gift transfer flow) and also in the review screen , the 'Death certificate registration number' and 'Date of death' text are little squished. Please take a look, thanks!!

from entity.

@chdivyareddy thanks, will take a look

from entity.

@chdivyareddy ready for retest

from entity.

Verified in DEV!

from entity.