Git Product home page Git Product logo

Comments (7)

SteveChapmanBCDX avatar SteveChapmanBCDX commented on June 3, 2024 1

@SteveChapmanBCDX, there's no limit on the note length in the db. Would you like there to be?

Good catch. Yes, let's some reasonable limit. Not sure what that might be. 2000 characters?

@SteveChapmanBCDX, we found a place where the previous developers limited the note to 1000 characters. Would you like to go with that?

@BCerki - Yes, let's use that limit.

from digital_marketplace.

BCerki avatar BCerki commented on June 3, 2024

Icon link: https://fontawesome.com/v5.15/icons/file-edit?style=solid

from digital_marketplace.

BCerki avatar BCerki commented on June 3, 2024

@SteveChapmanBCDX, there's no limit on the note length in the db. Would you like there to be?

from digital_marketplace.

SteveChapmanBCDX avatar SteveChapmanBCDX commented on June 3, 2024

@SteveChapmanBCDX, there's no limit on the note length in the db. Would you like there to be?

Good catch. Yes, let's some reasonable limit. Not sure what that might be. 2000 characters?

from digital_marketplace.

BCerki avatar BCerki commented on June 3, 2024

@SteveChapmanBCDX, the designs and AC don't have direction for error handling. Does the following work for you?

  • if the note is invalid (too short, wrong file format, etc.), in the modal, there's an error message and the submit button is greyed out like this:
    Screenshot from 2022-02-09 08-08-15
  • if there's a database error and the note doesn't save, you get a generic toast:
    Screenshot from 2022-02-09 08-13-48

from digital_marketplace.

SteveChapmanBCDX avatar SteveChapmanBCDX commented on June 3, 2024

@BCerki - Yes, this looks good.

from digital_marketplace.

BCerki avatar BCerki commented on June 3, 2024

@SteveChapmanBCDX, there's no limit on the note length in the db. Would you like there to be?

Good catch. Yes, let's some reasonable limit. Not sure what that might be. 2000 characters?

@SteveChapmanBCDX, we found a place where the previous developers limited the note to 1000 characters. Would you like to go with that?

from digital_marketplace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.