Git Product home page Git Product logo

Comments (3)

j-ittner avatar j-ittner commented on May 21, 2024

@ben-howt this is by design, so we can maintain a single make script across all 3 associated repos. Open for alternative suggestions - any ideas how to handle better? Would it be sufficient to explain the approach better in the developer guidelines?

from facet.

ben-howt avatar ben-howt commented on May 21, 2024

Thanks @j-ittner for the response; this makes sense to me as a design decision. I would suggest (and can raise a PR for) the following 2 changes:

  • Add a note in sphinx/source/contribution_guide.rst
  • Add a descriptive error if pytools is not found in the sys.path.insert segment of sphinx/make.py

from facet.

j-ittner avatar j-ittner commented on May 21, 2024

Addressed by #345

from facet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.