Git Product home page Git Product logo

Comments (5)

acromm avatar acromm commented on July 17, 2024 1

oh, that's a good one there using ng-if. What do you think about my solution? Is ng-if more efficient?

from angular-image-cropper.

acromm avatar acromm commented on July 17, 2024

As a workaround I changed the link function to this:

`
'link': function (scope, element, attributes, controller) {

            attributes.$observe('imageUrl', function (newValue) {

                if (newValue) {

                    controller.element = element[0];

                    controller.init();

                }
            });
        }

`

I'am really new to AngularJS and directives but it works for now. Maybe there is a more clean solution.

from angular-image-cropper.

bcabanes avatar bcabanes commented on July 17, 2024

Hi @acromm,
The directive has to have the image url to initialize the cropper UI and set all the dimensions, calculate ratio... etc.

You can just put an ngif on the directive waiting that your image-url is not undefined. When it will be defined, it will initiate the directive and should not throw error.

Edit:
It seems that we respond at the same time! ✨

from angular-image-cropper.

bcabanes avatar bcabanes commented on July 17, 2024

Hum, your solution works but is kinda really complex for a simple behaviour. Prefer Ngif, you will see immediately what you code do just by looking at it. You'll have more control.

from angular-image-cropper.

acromm avatar acromm commented on July 17, 2024

Ok Benjamin, thanks a lot for your help.

from angular-image-cropper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.