Git Product home page Git Product logo

Comments (2)

bbrister avatar bbrister commented on July 29, 2024

Thanks for the find. This is actually a very old and sloppy part of the code. I think I will rewrite it in the next version.

A much better algorithm would be to get a list of random row indices using Knuth shuffles, then copy those rows into the output.

However, mathematically speaking, the existing implementation does indeed return a uniformly random subset of the rows. It does not, however, permute those rows in a random way--the order of the remaining row indices is strictly increasing.

I never bothered to improve this before, since this function is only used in the RANSAC procedure, which so far hasn't been contributing much to the overall execution time.

from sift3d.

bbrister avatar bbrister commented on July 29, 2024

Refactored in version 1.4.5

from sift3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.