Git Product home page Git Product logo

Comments (4)

Cornelius-G avatar Cornelius-G commented on August 24, 2024

I think I can take a look at this, maybe together with @VasylHafych, to harmonize our efforts from marginal mode and plotting in this new type.

from bat.jl.

oschulz avatar oschulz commented on August 24, 2024

Thanks! We can split _auto_binning_nbins among separate subtypes of AbstractBinningAlgorithm, and have a FixedBinning too or so. Of course we should allow AbstractArrays and NamedTuples of binning algos (like you already implemented for plotting) so the user can specify binning in a per-parameter fashion.

from bat.jl.

Cornelius-G avatar Cornelius-G commented on August 24, 2024

Ok, so just to make sure I understand what you propose:

We will add a AbstractBinningAlgorithm as a supertype for the different automatic binnings, like Freedman–Diaconis and so on.
These types could then be passed to plot and bat_marginalize as a keyword argument like plot(samples, :a, bins=FD()) and would trigger the right version of _auto_binning_nbins.
But how exactly should we handle user-defined binning, like fixed number of bins or bin edges. Should it be possible to pass them directly as Ints and Ranges, like currently in plotting: plot(samples, bins=(200, -1:.01:1))?
Or would these need to be put into a subtype like FixedBinning, so that plot(samples, bins = FixedBinning(200, -1:0.1:1)) ?

from bat.jl.

oschulz avatar oschulz commented on August 24, 2024

Yes, that's the idea. FixedBinning would indeed be a subtype of AbstractBinningAlgorithm.

To make life more comfortable for the users, we should define Base.conv(::Type{AbstractBinningAlgorithm}, x) for symbols (e.g. :fd gets converted to Freedman–Diaconis()), scalars (like 500 means 500 bins, ends of range auto-adjusted) and ranges (0:0.2:1000 will be converted to an instance of FixedBinning).

from bat.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.