[Regression] BoxFit cover for placeholder and error builders about octo_image HOT 5 CLOSED

@davidmartos96 I fixed it in 0.3.0. Will update CachedNetworkImage this week.

from octo_image.

@renefloor
Thanks!
I took a look at the source code and example project and this fix would be a breaking change for octo image users. For instance, in the example, with the fix, the CircularProgressIndicator will need to be wrapped around a Center, as usual.

For the time being I was able to achieve the expected behavior wrapping my placeholders with a SizedBox.expand

from octo_image.

Yes I know, I also put BREAKING in the changelog for that: https://pub.dev/packages/octo_image/changelog
I indeed centered the progressIndicator, the CircularProgressIndicator as Placeholder was already centered: 3213069#diff-f8aabd1e3179bee091b84bf05b2b3fcf

I still think it is better to not center in the widget as that also doesn't happen for example in a container.

from octo_image.

I indeed centered the progressIndicator

Oh I didn't see that commit.

I still think it is better to not center in the widget as that also doesn't happen for example in a container.

Yes, I agree. It is also the behaviour of the Image widget in Flutter.

from octo_image.

Oh I didn't see that commit.

I can imagine, that wasn't part of the PR. I found a bit later that that one didn't center.

from octo_image.