Git Product home page Git Product logo

Comments (6)

zagaria avatar zagaria commented on June 18, 2024 1

@Guslington thanks for response! I added it to fork. Also, I fixed couple of issues in CloudFormation template. Can you, please, review https://github.com/zagaria/shelvery-aws-backups/commits/patch/handling_copies ?

And what the better approach/design for solve it in right way? I want to contribute but need to understand this software utility approach.

from shelvery-aws-backups.

zagaria avatar zagaria commented on June 18, 2024

@Guslington, @rererecursive please review when you have a time. Thanks!

from shelvery-aws-backups.

Guslington avatar Guslington commented on June 18, 2024

@zagaria thanks for raising this. It is a known issue at the moment and is currently in our backlog to resolve.

simplest approach would be to handle the exception inside copy_backup_to_region method and push a retry message to sqs.

from shelvery-aws-backups.

Guslington avatar Guslington commented on June 18, 2024

@zagaria What i think would be the best approach would be to have a try catch around the create_snapshot call and looking for the SnapshotCreationPerVolumeRateExceeded exception. then from there you could post a message to sqs for that resource using the ShelveryQueue class and setting a variable delay time on the message.

With the cloudformation changes i would like to keep the resource names
zagaria@388ed17#diff-363d481fe07d1094db2338998d381b71R134

And just wondering what you're using the condition for?

Why do you need the s3 bucket and path in the function uri?
zagaria@388ed17#diff-363d481fe07d1094db2338998d381b71R137
Are you using the sam build/package/deploy commands? As sam populates these fields behind the scenes when using those commands.

from shelvery-aws-backups.

zagaria avatar zagaria commented on June 18, 2024

@Guslington thanks for answer!

Condition only for keep template status when used web console and need to full recreate all resources. For me it's comfortably, nothing special)

S3 bucket and path used for different version and easy switch. Not used sam commands.

About create snapshots/copies - so it's possible to add try/catch to https://github.com/base2Services/shelvery-aws-backups/blob/develop/shelvery/ebs_backup.py inside necessary functions? Is it correct?

from shelvery-aws-backups.

Guslington avatar Guslington commented on June 18, 2024

@zagaria correct, you could catch the exception from the ebs_backup class but the issue will be sending the payload off to sqs with correct payload.

in which case it maybe be easier to catch the exception from the engine class

new_backup_id = self.copy_shared_backup(src_account_id, shared_backup)
and then post to sqs if exception occurs with a sqs delay of 5-10 minutes

from shelvery-aws-backups.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.