Comments (6)
@Guslington thanks for response! I added it to fork. Also, I fixed couple of issues in CloudFormation template. Can you, please, review https://github.com/zagaria/shelvery-aws-backups/commits/patch/handling_copies ?
And what the better approach/design for solve it in right way? I want to contribute but need to understand this software utility approach.
from shelvery-aws-backups.
@Guslington, @rererecursive please review when you have a time. Thanks!
from shelvery-aws-backups.
@zagaria thanks for raising this. It is a known issue at the moment and is currently in our backlog to resolve.
simplest approach would be to handle the exception inside copy_backup_to_region method and push a retry message to sqs.
from shelvery-aws-backups.
@zagaria What i think would be the best approach would be to have a try catch around the create_snapshot call and looking for the SnapshotCreationPerVolumeRateExceeded exception. then from there you could post a message to sqs for that resource using the ShelveryQueue
class and setting a variable delay time on the message.
With the cloudformation changes i would like to keep the resource names
zagaria@388ed17#diff-363d481fe07d1094db2338998d381b71R134
And just wondering what you're using the condition for?
Why do you need the s3 bucket and path in the function uri?
zagaria@388ed17#diff-363d481fe07d1094db2338998d381b71R137
Are you using the sam build/package/deploy commands? As sam populates these fields behind the scenes when using those commands.
from shelvery-aws-backups.
@Guslington thanks for answer!
Condition only for keep template status when used web console and need to full recreate all resources. For me it's comfortably, nothing special)
S3 bucket and path used for different version and easy switch. Not used sam commands.
About create snapshots/copies - so it's possible to add try/catch to https://github.com/base2Services/shelvery-aws-backups/blob/develop/shelvery/ebs_backup.py inside necessary functions? Is it correct?
from shelvery-aws-backups.
@zagaria correct, you could catch the exception from the ebs_backup class but the issue will be sending the payload off to sqs with correct payload.
in which case it maybe be easier to catch the exception from the engine class
shelvery-aws-backups/shelvery/engine.py
Line 354 in c43d3bd
from shelvery-aws-backups.
Related Issues (20)
- Ability to configure bucket names
- Listing large volume of snapshots on cleanup times out lambda function HOT 2
- documentDB snapshot support HOT 1
- Recommendations and best practices HOT 6
- postinstall is missing HOT 7
- Can we have shelvery wrapped as Cfhighlander module HOT 2
- Update the sam deploy script to use the sam cli HOT 1
- How to limit AMI creation to 1 EC2 with aws cli? HOT 4
- Problem with clean_backups and long retention time HOT 2
- yaml error while running the code in AWS Lambda HOT 4
- shelvery.data s3 bucket should be set to block all public access
- support latest version of pyyaml
- shelvery fails to copy shared backup
- improve integration tests and add test cases
- create github action to release shelvery pip package to pypi
- local variable 'current_policy' referenced before assignment HOT 1
- don't take backup when retention is set to 0 and fall back to next backup type
- handle sharing rds snapshot rate limiting HOT 1
- Fix unit tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shelvery-aws-backups.