Git Product home page Git Product logo

Comments (6)

aflock avatar aflock commented on July 28, 2024 1

Makes sense as something you need to do. This API won't be the correct way to implement that however - possibly you could use some docker tooling to monitor the version of software you are running?

from node.

PeaStew avatar PeaStew commented on July 28, 2024 1

Sure, why make it easy

from node.

aflock avatar aflock commented on July 28, 2024

Hey @PeaStew, this is a geth API and will return the version of Geth currently running
https://github.com/ethereum/go-ethereum/blob/2274a03e339f213361453590b54917bbfd0a0c31/node/api.go#L329
It's not intended to track the release version of this node software.
The best way to track released versions would be to subscribe to this projects releases
Is that what you're trying to do?

from node.

PeaStew avatar PeaStew commented on July 28, 2024

Hey @PeaStew, this is a geth API and will return the version of Geth currently running https://github.com/ethereum/go-ethereum/blob/2274a03e339f213361453590b54917bbfd0a0c31/node/api.go#L329 It's not intended to track the release version of this node software. The best way to track released versions would be to subscribe to this projects releases Is that what you're trying to do?

We are trying to track our version of the software running on our load balancer vs the version that has been released, so that we get alerting on new versions. This is pretty normal to need to do.

from node.

mdehoog avatar mdehoog commented on July 28, 2024

Hey @PeaStew, thanks for raising the issue! The current version comes from these constants: https://github.com/ethereum-optimism/op-geth/blob/v1.101106.0/params/version.go#L32-L37

I agree it would be preferable for web3_clientVersion to return the correct version information. I'm working with the Optimism team to figure out a way to keep this in sync with the released tag. Note that any fix would pin it to the op-geth version, not necessarily the version of the docker image in this repo, as this repo is a combination of a couple of pieces of software that are versioned separately.

from node.

mdehoog avatar mdehoog commented on July 28, 2024

this is now fixed:

> curl -d '{ "jsonrpc":"2.0", "method":"web3_clientVersion", "params":[ ], "id":1 }' -H "Content-Type: application/json" https://goerli.base.org
{"jsonrpc":"2.0","result":"Geth/v1.101200.1-rc.2-36831023-20230823/linux-amd64/go1.19.12","id":1}

from node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.