Git Product home page Git Product logo

Comments (3)

Barre avatar Barre commented on May 20, 2024

I have tried both *.dropbox.com and just dropbox.com, and in both cases subdomains continue to generate TLS handshake errors in the log. Adding each offending subdomain fixes it.

The wildcard exclusion behavior is not exposed to end users by (current) design for three debatable reasons:

  • We use globset which is designed for paths here: https://github.com/Barre/privaxy/blob/main/privaxy/src/server/proxy/exclusions.rs#L9
  • If it is useful to exclude *.example.com, such an exclusion is probably useful to every privaxy user; and should instead be contributed to the project directly.
  • Excluding *.example.com may not be what most users would actually want to achieve if something is not working; it is probably more in the lines of "this website don't work properly, let's try this".

I also noticed that the UI says that domains that have handshake failures will be automatically added to the exclusion list, but that doesn't seem to be happening in my case.

Ah, thanks, I will fix this :)

It is a quirk from where it was the case. I then removed this behavior when the project was not yet published as I thought that it would then be trivial for websites to trigger this behavior and get excluded.

from privaxy.

dhc02 avatar dhc02 commented on May 20, 2024

It is a quirk from where it was the case. I then removed this behavior when the project was not yet published as I thought that it would then be trivial for websites to trigger this behavior and get excluded.

That's a great point. If this became widespread, the effectiveness of Privaxy could evaporate. Perhaps a good compromise would be to add handshake error domains into a checkbox list in the UI, so that it's quick and easy to add them as exclusions if that's what the user wants.

In this case, a total of 5 dropbox.com and dropboxapi.com domains were getting handshake errors (all from the MacOS client, not from visiting the website).

from privaxy.

Barre avatar Barre commented on May 20, 2024

I fixed the explanatory text in d2bfaeb.
I'm closing as of now as it's not really clear if wildcards are useful as a feature, except when done according to a vendor defined list such at what apple does here: https://support.apple.com/en-us/HT210060

from privaxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.