Git Product home page Git Product logo

Comments (4)

juha-h avatar juha-h commented on June 12, 2024

Here is more info. Both baresip and ZRTPCPP source dirs are located in /usr/src/orig dir. If I have in debian/rules:

	dh_auto_configure -- -DCMAKE_BUILD_TYPE=Release -DMODULES=$(MODULES) -DAPP_MODULES=$(APP_MODULES) -DAPP_MODULES_DIR="../baresip-app-modules" -DGZRTP_INCLUDE_DIRS="../ZRTPCPP"

I get

-- Could NOT find GZRTP (missing: GZRTP_INCLUDE_DIR)

If I use absolute path:

	dh_auto_configure -- -DCMAKE_BUILD_TYPE=Release -DMODULES=$(MODULES) -DAPP_MODULES=$(APP_MODULES) -DAPP_MODULES_DIR="../baresip-app-modules" -DGZRTP_INCLUDE_DIRS="/usr/src/orig/ZRTPCPP"

I get

-- Found GZRTP: /usr/local/lib/libzrtpcppcore.a  

How come that the path ../ZRTPCPP does not work, when the corresponding APP_MODULES_DIR works?

I'm pretty sure that earlier GZRTP was found without any GZRTP_INCLUDE_DIRS in debian/rules.

from baresip.

sreimers avatar sreimers commented on June 12, 2024

find_package is now executed from module path. So I think this is why the relative path does not work anymore.

find_package(GZRTP)

Maybe something like this works:

find_path(GZRTP_INCLUDE_DIR
    NAMES common/osSpecifics.h
    HINTS
        "${GZRTP_INCLUDE_DIRS}"
        "${GZRTP_HINTS}/include"
    PATHS ${CMAKE_SOURCE_DIR}/../ZRTPCPP
)

from baresip.

juha-h avatar juha-h commented on June 12, 2024

@sreimers Thanks, the above diff worked. I guess the same change should be applied to this:

find_library(GZRTP_LIBRARY
    NAME zrtpcppcore
    HINTS
        "${GZRTP_LIBRARY_DIRS}"
        "${GZRTP_HINTS}/lib"
    PATHS ../ZRTPCPP/clients/no_client
)

and also to cmake/FindWEBRTC_AECM.cmake.

from baresip.

juha-h avatar juha-h commented on June 12, 2024

Fixed by #2924.

from baresip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.