Comments (3)
I just tested my filter like this:
println(registry.getCounters.keySet().size())
println(registry.getGauges.keySet().size())
println(registry.getCounters(new DataLakeEtlMetricFilter()).keySet().size())
println(registry.getGauges(new DataLakeEtlMetricFilter()).keySet().size())
And is working OK. So it seems that is not taking the one that is given as an argument in ScheduledReporter.
from spark-metrics.
It seems that in DropwizardExport is not using any filter,
@Override
public List<MetricFamilySamples> collect() {
ArrayList<MetricFamilySamples> mfSamples = new ArrayList<MetricFamilySamples>();
for (SortedMap.Entry<String, Gauge> entry : registry.getGauges().entrySet()) {
mfSamples.addAll(fromGauge(entry.getKey(), entry.getValue()));
}
for (SortedMap.Entry<String, Counter> entry : registry.getCounters().entrySet()) {
mfSamples.addAll(fromCounter(entry.getKey(), entry.getValue()));
}
for (SortedMap.Entry<String, Histogram> entry : registry.getHistograms().entrySet()) {
mfSamples.addAll(fromHistogram(entry.getKey(), entry.getValue()));
}
for (SortedMap.Entry<String, Timer> entry : registry.getTimers().entrySet()) {
mfSamples.addAll(fromTimer(entry.getKey(), entry.getValue()));
}
for (SortedMap.Entry<String, Meter> entry : registry.getMeters().entrySet()) {
mfSamples.addAll(fromMeter(entry.getKey(), entry.getValue()));
}
return mfSamples;
}
from spark-metrics.
Hi @gsumar , you are right the DropwizardExports.collect()
is not taking into account any metrics filters. A solution that I can imagine is to derive from DropwizardExports
and override the public List<MetricFamilySamples> collect()
method such as to take into account a metrics filter which can be passed in via constructor parameter of the derived class.
What do you think?
from spark-metrics.
Related Issues (20)
- Metrics namespace HOT 11
- Pushgateway Read timed out HOT 2
- Want to understand that this spark matrics repo will work with prometheus in Hadoop cluster ? HOT 4
- Release Spark provided fix to maven HOT 2
- No Metrics From Spark Executors (Classes are being instantiated) HOT 10
- Metrics name pre-processing by custom Prometheus sink is working for only one component(driver/executor/applicationMaster) HOT 10
- Filter metrics HOT 10
- Metric Name RegEx Replacement doesn't work with JMX HOT 2
- Spark Metrics Stop Pushing After Pushgateway Restarts
- Configure sink to stop sending job as label/group-key HOT 3
- Metrics filter doesn't work
- Add remote_write to PrometheusSink
- Security Policy violation Binary Artifacts HOT 315
- Security Policy violation Branch Protection HOT 314
- Prometheus Sink is not working with SparkPi
- VictoriaMetrics HOT 2
- Repetitions of last metric value HOT 2
- Adding the ability to set custom labels on metrics
- com.banzaicloud:spark-metrics_2.12:3.1-1.0.0 version Not published to maven central HOT 3
- Only driver metrics visible on local
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spark-metrics.