Git Product home page Git Product logo

Comments (3)

tinyzimmer avatar tinyzimmer commented on September 4, 2024

Just to add to the discussion - what should be the desired behavior when a cluster has topic deletion disabled and a KafkaCluster or KafkaTopic gets deleted? In the current state on master, if I am understanding sarama's documentation correctly, is that no error will be raised but the topic will remain in Kafka/Zookeeper. So an attempt to recreate the topic on a new or existing cluster using the same zookeeper will fail.

from koperator.

baluchicken avatar baluchicken commented on September 4, 2024

From Kubernetes perspective Kafka Topics and Users are external resources. In release 0.7.0 we removed the loop which periodically checked Kafka Topics. Since it is an external resource the operator will not receive any event in case of modification. I think this is the way to go.
It has some benefits like we don't need to implement an inner watcher logic for the Kafka resources.
Of course it has some drawbacks as well since if the user deletes a topic created through CR the operator will recreate it once an update happens on the related CR.

from koperator.

prune998 avatar prune998 commented on September 4, 2024

That's a fair move. Now we know how to handle such a situation. Thanks @baluchicken
Is this clearly stated in the docs ? (will check ASAP)
I think this can be closed then.

Thanks again for your great work

from koperator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.