Git Product home page Git Product logo

Comments (13)

yleflour avatar yleflour commented on May 26, 2024

Linked to #6 , plugin is currently incompatible with npm (yarn only) a fix is being developed

from react-native-make.

huangtony avatar huangtony commented on May 26, 2024

I'm still having this problem using 1.0.3 and react-native set-splash --path logo.png --resize center.

warn Package @bam.tech/react-native-make has been ignored because it contains invalid configuration. Reason: Unexpected token {

Installed using yarn add -D @bam.tech/react-native-make.

react-native-cli: 2.0.1
react-native: 0.61.1

At first I installed it on react-native 0.60.5, uninstalled it, upgraded to 0.61.1, reinstalled but still have the same issue. I don't see the commands in react-native -h either.

from react-native-make.

yleflour avatar yleflour commented on May 26, 2024

from react-native-make.

logicallydimp23 avatar logicallydimp23 commented on May 26, 2024

@huangtony try to use v1.02 yarn add -D @bam.tech/[email protected]
It worked with react-native version 0.61.2

from react-native-make.

huangtony avatar huangtony commented on May 26, 2024

@logicallydimp23 Thanks, v1.02 worked fine.

from react-native-make.

yleflour avatar yleflour commented on May 26, 2024

Hello, @mcoeur , can you tell me your react-native-cli package.json local install path within your project? It seems that I haven't handled all possibilities

from react-native-make.

tomeberle avatar tomeberle commented on May 26, 2024

Having this issue as well with RN 0.60.5 / npm install..

from react-native-make.

logicallydimp23 avatar logicallydimp23 commented on May 26, 2024

Having this issue as well with RN 0.60.5 / npm install..

@tomeberle as a workaround have you tried v1.0.2?
yarn add -D @bam.tech/[email protected]

from react-native-make.

tomeberle avatar tomeberle commented on May 26, 2024

@logicallydimp23 Yes, but I had issues as well as the project is using npm and not yarn. Specifically, the yarn install was failing on MS Appcenter.

from react-native-make.

yleflour avatar yleflour commented on May 26, 2024

@logicallydimp23 Can you give me:

  • Using npm or yarn?
  • Which version ?
  • Which react-native-cli version ?
  • Which react-native (project version) ?

from react-native-make.

yleflour avatar yleflour commented on May 26, 2024

By the way, I need all the help I can get solving this issue.

For your information, previous invalid configuration errors were because @react-native-community/cli/package.json couldn't be resolved.

Currently supported paths (cwd is your react-native project directory):

  • node_modules/@react-native-community/cli/package.json (yarn)
  • node_modules/react-native/node_modules/@react-native-community/cli/package.json (npm)

If your path doesn't match either of those, can you tell me:

  • What your path actually is
  • What your os, node, npm, yarn, RN, RN-cli versions are

from react-native-make.

logicallydimp23 avatar logicallydimp23 commented on May 26, 2024

@yleflour

  • Using npm or yarn? Yarn
  • Which version ? Yarn v1.17.3, @bam.tech/react-native-make v1.0.2
  • Which react-native-cli version ? react-native-cli: 2.0.1
  • Which react-native (project version) ? react-native: 0.60.5

from react-native-make.

finnp avatar finnp commented on May 26, 2024

I went to the node_modules/@bam.tech/react-native-make/dist/rn-plugin.config.js file and removed the V1 detection script:

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
require("colors");
const modules_1 = require("./modules");
const path_1 = require("path");
const rn_compatibility_layer_1 = require("./rn-compatibility-layer");
const v2Config = {
    commands: [modules_1.setIconCommand, modules_1.setSplashScreenCommand],
};
exports.rnPluginConfig = v2Config;

After that it was working correctly.

Maybe you can just deprecate v1?

from react-native-make.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.